Hi Guys

The field weight for WEBFM attachements is not being updated from CCK field management interface. The problem is a bad implementation of HOOK_content_extra_fields()

I'm attaching a patch that fixes the problem

CommentFileSizeAuthor
webfm.module.patch444 bytesjm.federico

Comments

nhck’s picture

nhck commented
Status: Active » Reviewed & tested by the community

Nice find.

Confirmed&tested.

nhck’s picture

nhck commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD http://drupal.org/cvs?commit=369222

Thank you for reporting this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

cgmonroe’s picture

cgmonroe commented

Did this get tested with the changes made on this issue?

http://drupal.org/node/442336

That uses the "webfm-attachments" key and not the "webfm-attach" key that this patch uses.

Also, I think there may be issues with the default weight of 10. I think this tends to make the webfm attachments default to the top of the list. Not sure that's were it should be.

Onklo’s picture

Onklo commented

@#4 You are absolutely right. This patch breaks cck field weight in webfm 6.x-2.13-beta1.
I changed "webfm-attach" to "webfm_attachments" In webfm.module line 439 and the reordering worked again.

Before:

$extras['webfm-attach'] = array(

After:

$extras['webfm_attachments'] = array(