At present playlist xml files are written to the file system, under sites/all/files/playlists.

This isn't necessary. We can cache the xml output in the cache table, and then access it directly using Drupal.

Tested locally and we access playlists using the path /swftools/playlist/xxxxxxx.xml

If the file is in the cache, that gets served. It isn't, it is generated.

This keeps the file system neat, and means we no longer have a danger of filling up with stray xml files. When we flush the site cache tables we flush the xml, and it just gets rebuilt.

It means we can now eliminate calls to check for, and create, the playlist directory, which is made every time we try to access a playlist.

This feature will be in SWF Tools 6.x-3.x as part of the general improvements and optimisations.

Comments

Stuart Greenfield’s picture

Stuart Greenfield commented

Tested and tweaked some more. This is looking very stable, and fast. Re-committed on HEAD to use SWF Tools own cache table {cache_swftools}. See #754676: Implement SWF Tools cache.

A number of internal functions have now been removed, and other functions greatly simplified, as a result of this change.

Note - committed on HEAD, not DRUPAL-6--3. I didn't think these features would steady out as quick as they did!

Release 6.x-3.x may come from HEAD, not the planned branch! Or maybe we skip 6.x-3.x completely and jump to 6.x-4.x!!

Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Active » Needs review

Released for testing in BETA2.