CVS edit link for attila.fekete

Developing Soundcloud module for Drupal.

I want to create a module that covers the following functions:
- soundcloud filter: soundcloud URL-s will be converted into embed code. the filter format is [soundcloud:URL] (additional parameters will be supported)
- soundcloud CCK field - and a CCK widget to customize the player
- these functions will work with both tracks and sets.
- using oAuth to get private content from Soundcloud (if possible)
- uploading tracks from Drupal to Soundcloud account
- using Soundcloud API (http://wiki.github.com/soundcloud/api/) to get additional information from tracks

CommentFileSizeAuthor
#2 soundcloud_filter.zip2.64 KBattila.fekete

Comments

attila.fekete’s picture

attila.fekete commented
Status: Postponed (maintainer needs more info) » Needs review

Only the filter is available at the moment. Module attached to this comment. If the colorpicker module is installed and enabled (http://drupal.org/project/colorpicker), it's easier to pick a player color.
Thank you for your review!

attila.fekete’s picture

attila.fekete commented
StatusFileSize
new soundcloud_filter.zip2.64 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 

function soundcloud_filter($op, $delta = 0, $format = -1, $text = '') {		
	
	switch($op) {	
		case 'list':
			return array(
				0 => t('SoundCloud filter')
			);
			
		case 'description':
			return t('Description: replaces [soundcloud:URL] with embedded code');
			
		case 'settings':		
			return soundcloud_filter_settings($format);
			//break;
		
		case 'no cache': // FALSE if not in test-mode
			return TRUE;
		
		case 'prepare':
			return $text;
			
		case 'process':

Use spaces instead of tabs.

		$output .= '<object height="' . $sc['height'] . '" width="' . $sc['width'] . '%"><param name="movie" value="http://player.' .$parsed_url['host'] . '/player.swf?' . $params.'"></param>';
		$output .= '<param name="allowscriptaccess" value="always"></param><embed allowscriptaccess="always" height="'.$sc['height'].'" src="http://player.'.$parsed_url['host'].'/player.swf?'.$params.'" type="application/x-shockwave-flash" width="'.$sc['width'].'%"></embed></object>';
		$text = $output;

Minro feature wish: Make this part a theme function.

?>

Don't close the php tag at the end of files.

The rest looks fine.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

There have not been replies in the last week. I am marking this application as won't fix.