User list not showing in most recent version of chatbox [#75564]

The code on line 222 of the module should be like this:

parent.nicklist.location.href = "'. url("chatbox/nicklist", NULL, NULL, 1) . $rand .'";

With the rand after the url function. Before the url function was causing the rand variable to be urlencoded which caused the browser to not find the correct page and therefore the list didn't show up. Hope this helps. Sorry this isn't in patch form. I didn't download this from CVS.

Comment	File	Size	Author
#3	chatbox-userlist.patch	1.02 KB	darren oh

Comments

Comment #1

ricmadeira commented 7 August 2006 at 15:19

It works fine! Thanks for the patch!!

Comment #2

alexmarkley commented 13 August 2006 at 04:30

I too had this problem. My fix is to use the url() function correctly:

(At line 211)

$rand = 'forcerefresh=' . rand(1000, 9999);

(Instead of '&forcerefresh...')

(At line 222)

parent.nicklist.location.href = "'. url("chatbox/nicklist", $rand, NULL, 1) .'";

(Instead of putting $rand in the drupal path argument.)

Since the second argument is designed for query strings, url won't escape the query characters. :-P (Additionally, it shouldn't randomly break later on...)

If you're curious, check the url() documentation.

ttyl
--Alex Markley