Account details are not included in customer invoice email since $_SESSION['new_user'] is unset prior to ca_pull_trigger() [#755944]

when de-selecting "Send new customers a separate e-mail with their account details.", the invoice mail doesn't contain the new username and password because $_SESSION['new_user'] is cleared before the template gets parsed

to fix it, in ./uc_cart/uc_cart.module at line 1288 move the unset last, like this:

  // Empty that cart...
  uc_cart_empty(uc_cart_get_id());

  module_invoke_all('uc_checkout_complete', $order, $account);
  ca_pull_trigger('uc_checkout_complete', $order, $account);

  // Clear our the session variables used to force the cart workflow.
  unset($_SESSION['cart_order'], $_SESSION['do_complete'], $_SESSION['new_user']);

how does it impact the 2 function calls? seems to be working ok, alternatively you can split it in 2 unset calls and just unset the new_user last

Comment	File	Size	Author
#9	uc_cart_ptach_2.patch	743 bytes	sarjeet.singh
#9
#7	uc_cart_ptach_1.patch	687 bytes	sarjeet.singh
#7
#5	uc_cart_ptach.patch	621 bytes	sarjeet.singh
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Offlein CreditAttribution: Offlein commented 13 May 2010 at 16:43

This seemed to do just what I needed, and I've yet to see any negative consequences.

Comment #2

EvanDonovan CreditAttribution: EvanDonovan commented 25 November 2010 at 01:52

Title:

new customer invoice email with no account details

» Account details are not included in customer invoice email since $_SESSION['new_user'] is unset prior to ca_pull_trigger()

Is there any reason why this is not being done already? I am experiencing this issue also in 2.3.

Comment #3

EvanDonovan CreditAttribution: EvanDonovan commented 3 January 2011 at 20:57

Version:	6.x-2.2	» 6.x-2.4
Priority:	Normal	» Major

I think this is a major bug; I'm still seeing it in 2.4. Going to try the suggested code & see if I run into issues. RTBC if none.

Comment #4

YK85 CreditAttribution: YK85 commented 28 February 2011 at 13:55

subscribing

Comment #5

sarjeet.singh CreditAttribution: sarjeet.singh commented 11 May 2011 at 08:54

Priority:

Major

» Critical

File	Size
uc_cart_ptach.patch	621 bytes

I faced same problem. abaddon's solution worked fine.

I made a patch for it. its need to review.

Comment #6

11 May 2011 at 09:12

Status:

Needs review

» Needs work

The last submitted patch, uc_cart_ptach.patch, failed testing.

Comment #7

sarjeet.singh CreditAttribution: sarjeet.singh commented 11 May 2011 at 09:23

Status:

Needs work

» Needs review

File	Size
uc_cart_ptach_1.patch	687 bytes

I made new patch(uc_cart_ptach_1.patch). please review it.

Comment #8

11 May 2011 at 09:42

Status:

Needs review

» Needs work

The last submitted patch, uc_cart_ptach_1.patch, failed testing.

Comment #9

sarjeet.singh CreditAttribution: sarjeet.singh commented 11 May 2011 at 09:57

Status:

Needs work

» Needs review

File	Size
uc_cart_ptach_2.patch	743 bytes

I made new patch(uc_cart_ptach_2.patch) with git(linux). please review it.

Comment #10

longwave

he/him

English

CreditAttribution: longwave commented 11 May 2011 at 10:09

Priority:

Critical

» Major

Ignore the testbot failures, it doesn't work properly at the moment.

Comment #11

11 May 2011 at 10:12

Status:

Needs review

» Needs work

The last submitted patch, uc_cart_ptach_2.patch, failed testing.

Comment #12

Offlein CreditAttribution: Offlein commented 11 May 2011 at 15:03

Status:

Needs work

» Reviewed & tested by the community

This ptach has been working for me in a live environment for about a year now. I think it should just be committed.

Comment #13

EvanDonovan CreditAttribution: EvanDonovan commented 11 May 2011 at 17:39

I agree with Offlein. I didn't test this particular patch to see whether it applies, but it does exactly what I am now doing on my production sites (and have been for about 6 months).