The themes settings page has two settings for the logo and favicon where the descriptions say exactly the same as the titles, only using three more words. This patch simply removes them. No API changes, just less cruft and less to translate (because that's how I came across them).

CommentFileSizeAuthor
#8 remove_form_element-756500-8.patch1.37 KBvalentine94
#6 remove_form_element-756500-6.patch1.5 KBvalentine94
#4 text_changed_and_description_removed-756500-4.patch3.28 KBPolonium
remove_crufty_theme_setting_descriptions_00.patch1.26 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Just realised I forgot to attach screenshots.
Before:
Only local images are allowed.
After:
Only local images are allowed.

nvanhove’s picture

nvanhove commented
Status: Needs review » Needs work

"If toggled on, the following logo will be displayed".
There's no logo following, so the text should be changed.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned
Polonium’s picture

Polonium commented
Issue summary: View changes
StatusFileSize
new text_changed_and_description_removed-756500-4.patch3.28 KB

I rename description of logo settings.

dcam’s picture

dcam commented
Issue tags: +Novice

Setting the issue status to Needs review will cause your patch to be automatically tested.

While I would normally do this for you, in this case your patch could use some additional work.

For one thing, I can't apply it. I'm getting a fatal error.

Second, lines 470 and 505 are changed unnecessarily. It's normal Drupal coding practice to put a comma after the last element of an array. I have no idea why the commas weren't included after the #description elements, but they can certainly be left in place on the lines that aren't being deleted.

Third, it looks like the descriptions are being replaced by whitespace, but I can't verify that because I can't apply the patch.

BTW, this doesn't apply to D8. All of these descriptions were removed from it.

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Status: Needs work » Needs review
StatusFileSize
new remove_form_element-756500-6.patch1.5 KB

Patch re-roll.

dcam’s picture

dcam commented
Status: Needs review » Needs work

Good work, @Valentine94. That first description that's being changed should just be removed though. I don't know why it was being changed and not removed by the earlier patch.

valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented
Status: Needs work » Needs review
StatusFileSize
new remove_form_element-756500-8.patch1.37 KB

First description fix.

epophoto’s picture

epophoto commented

We are testing the above patch out at #drupalconla

epophoto’s picture

epophoto commented
Status: Needs review » Reviewed & tested by the community

Tested at DrupalConLA in the mentored sprint and verified that the redundant descriptions are successfully removed.

Tested by epophoto and adriancotter

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Needs work

Yeah, these are pretty repetitive, but it also seems like we're losing some important information here if we simply remove them, namely that "default" means "the one provided by the theme itself". In Drupal 8 the checkbox labels themselves were also changed to "Use the default logo supplied by the theme" and "Use the default shortcut icon supplied by the theme", presumably to address that... shouldn't we be doing that here too?

If we can find the Drupal 8 issue that did this change, that could be useful so we can "officially" backport it and also to make sure we're not missing anything else that was already discussed.

Richard Buchanan’s picture

Richard Buchanan commented
Status: Needs work » Closed (duplicate)

Found the Drupal 8 issue dealing with these descriptions. Marking this as a duplicate of #1376166: Custom logo and favicon functionality inanely tries to support absolute local file paths, which is already tagged as needing a backport to Drupal 7.