"content_moderation_revision_state not correctly updated

The live state is saved in the content_moderation_revision state. Existing nodes, which existed, when the module has been activated, have no entry in the live table, thats correct. That rather a feature request

i have the filter working on my installation but only used it for non-live states, so maybe there is a problem.

- Ususaly when a node is in the transaction aprove->live a entry will be created in the content_moderation_revision_state table. if that does not happen (did happen for me), this is a bug
- for existing nodes, which do not yet have been moderated and set to live (eventhough they are live already, but no transaction happened) this state is not yet there.

AFAIK this is a feature request:

Create live state for all exisiting nodes when activitatin content_moderation.

Please confirm if i got that right :)

Well, only the last "live" version has the "live" state in that table, not all yet "live" versions. Those informations are then saved in the history table. I can see a fairly good point in list "all live revisions of a node". But this sounds more like a feature request once again.

scenarion 1:
Please open a feature request :)

scenario 2:
Iam confused because you talk about nodes, not revisions of those. Please rephrase so i can better follow you. In general the _last_ live-revision has the "live" state in that table. "old live" versions have the "none" state actually, but see my first sentences for this issue.

scenario 3: same here, could you use "revision" and redeclare? :)

Thanks for the input!

Well that needs some investagation. Did you try this on a clean D6.16 installation with content_moderation installed?

What kind of DB do use? Mysql or postgresql? do you have any errors in the watchdog

Well now its time for me to get some more debug details. Guess you have to wait until i have fixed it, maybe next week, pretty busy this one.

Anyway thanks for all the informations

Hi i got a small hint, the INSERT query is not used for tables content_moderation_node_history, Browse content_moderation_revision_state
May it will be useful to debug..

I guess not :) dont worry, happens

Your fix is perfectly correct.

The problem was

/*
 * Implementation of hook_form_submit
 */
function content_moderation_change_state_form_submit($form, &$form_state) {
  global $user;

  $node = $form_state['values']['node'];
  $curstate = $form_state['values']['oldstate'];
  $nextstate = $form_state['values']['nextstate'];
  $comment = $form_state['values']['comment'];

  // Change the revision state.
  _content_moderation_update_revision_state($node->vid,$node->nid,$nextstate);

  // If the state is live, change the current live version.
  // TODO: the "final" state maybe should not be hardcoded later.
  if($nextstate == 'live') {
    _content_moderation_set_live($node->vid,$node->nid);
    drupal_set_message(t("This revision !vid has now been published as the new live version.", array('!vid' => $node->vid)));
  }

Here, first the new revision is set live and then after that, ALL live revisions are set to none, including our new revisions. So your login included "remove all live states except the current new created one", which is identified by the vid.

Thanks for the contribution. That fix will be inlcuded in 1.3