Sorry for this issue and the harsh words, but:

This module is contradictory to most principles listed on http://drupal.org/principles

Most of the functionality should be contributed to the actual/real project it affects.

AFAICS, none of the functions should be required by any of the modules that depend on this module (or the functionality doesn't belong into this module in reality). Some functions only seem to try to fix bugs in other modules anyway.

Comments

ndeschildre’s picture

ndeschildre commented

Hey,

Ok I agree with you with the bugfix that should not be here (aef_utilities_views_base_override.js) and in fact I thought I removed it from the tarball. But that's the only one. The rest a features used by all the dependents modules.

So basically I should copy paste all the functions that are needed in each modules that depends of this one (all the 14 of them)? It would lead to much duplication and would be against coding principles.