Firstly thanks for the authors, this is a very useful module!
But.. :)

The translated content lose all of additional node information durint the translate process..
(the module create an empty node and fill the title and body with the translated text)
I think It would be better to clone the whole node object (include: menu, tags, publishing options, cck fields, etc) and translate the body and title and other fields.

Comments

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Ok, responding so this is in my queue. There's a bit of work to do on how this module copies the original nodes. This can be added to the list. I need to browse the issue queue and refresh my memory, but I've a feeling someone came up with a much more elegant solution for doing this already, which might well fix this issue too.

kepesv’s picture

kepesv commented

A solution for the problem:

After this line (~52.line)

      node_object_prepare($new_node);

insert these lines:

      $new_node = clone $node;
      $new_node->nid = NULL;
      unset($new_node->menu); //optional
spacereactor’s picture

spacereactor commented

nice, now the cck information is clone and pass over to the new translated node. But beside the title and body get translated, the rest of cck data still the remain as default language.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

We need to be more careful than that here. There are a load of options within i18n itself to determine whether or not taxonomy data, CCK fields, etc. are copied to translations. This module should respect those settings, not just ignore them and copy regardless. Use the solution in #2, by all means, if it suits your needs but it won't be the committed fix. The committed fix will need to check the i18n settings for the content type and respect them.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Active » Closed (duplicate)

This is really a duplicate of #720866: Module should respect i18n settings for inheriting data from parent node - please carry on discussions there.