warning: preg_match() [function.preg-match]: Unknown modifier 'p' /[..]/swftools/swftools.module on line 1512

That doesn't sound good - and I've not seen this locally. How are you putting your swf content on the page, and are you using a public or private file transfer? Code around that point of the module is associated with private transfers.

I'll run some tests tonight and see if I get the same.

Did this error occur immediately after installing the beta, or did it start later?

Inconsistent appearance might be the case if the browser is caching the swf locally so it doesn't fetch it back from the server?

But then I have no idea why the error should appear on admin pages when there's nothing for SWF Tools to do.

Leave it with me!

P.S. I'm afraid you get the dubious honor of first bug filed against the new version of SWF Tools!

I don't get this locally, and the content of swftools.module at line 1512 is just the closing brace on a function.

In that area is the function to let SWF Tools serve files not uploaded via an upload module, and there's a preg-match at line 1488

In total the code around this area should be

function swftools_file_download($file) {

  // If SWF Tools is allowed to grant access then check to see if access will be allowed
  if (variable_get('swftools_grant_access_to_private_files', SWFTOOLS_GRANT_ACCESS_TO_PRIVATE_FILES)) {

    // Get extension of file in question
    $extension = pathinfo($file, PATHINFO_EXTENSION);

    // Get list of extensions that SWF Tools can grant access to
    $extensions = variable_get('swftools_grant_access_extensions', SWFTOOLS_GRANT_ACCESS_EXTENSIONS);

    // Need access to the user object
    global $user;

    // Check if SWF Tools should grant access - skip the check for user #1
    if ($user->uid != 1) {
      $regex = '/\.('. ereg_replace(' +', '|', preg_quote($extensions)) .')$/i';
      if (!preg_match($regex, $file)) {
        return;
      }
    }

    // Build an array of types that SWF Tools can react to
    $mime_types = array(
      'swf'  => 'application/x-shockwave-flash',
      'flv'  => 'application/octet-stream',
      'xml'  => 'text/xml',
      'mp3'  => 'audio/mpeg',
      'jpg'  => 'image/jpeg',
      'jpeg' => 'image/jpeg',
      'png'  => 'image/gif',
    );

    // If file is one of the above types, based on the extension, return headers
    if ($mime_types[$extension]) {
      return array(
        'Content-Type: '. $mime_types[$extension],
        'Content-Length: '. filesize(file_create_path($file)),
      );
    }
  }
}

function is on line 1471, and the closing } is line 1512 where your error is reported. There is a preg_match in line 1488.

Can you check your swftools.module in a text editor and verify that the ID at the top says swftools.module,v 1.20.2.16.2.38 2010/03/30 00:02:01 stuartgreenfield

Then check that your code around these lines matches. I did have an issue way back when a package got corrupted and users had bits of an old module. No-one else has reported issues, but you never know.

Locally I'm running the CVS code from the tag that generated the package and it's fine.

I've placed an mp3 file that I didn't upload and can't acces it at first. When I enable SWF Tools to let me access the file it plays fine and I get no errors. If your package is not corrupted then I can't see why you're getting an error, and not at that line.

If the preg_match is going wrong (although the line number is wrong!) then the only other thing I can suggest is to try and find out what the regex string is.

To do this add the following lines in swftools.module right underneath global $user in the above function, so it reads

    // Need access to the user object
    global $user;
    
    $regex = '/\.('. ereg_replace(' +', '|', preg_quote($extensions)) .')$/i';
    drupal_set_message($regex);

Now clear your site cache (Administer > Site configuration > Performance > Clear cached data). Then view a page with some audio/video, then view again. You should get a green message box with the regex string in it. Can you paste what you see.

On my test site I get /\.(swf|flv|xml|mp3|jpg|jpeg|png)$/i. That way we can make sure you're getting a valid string.

I was just about to hit Save on this when I realised you said you are playing back QuickTime/H.264 files. Have you realised there are a few tweaks needed?

You need to add the appropriate file extension to SWF Tools list of extensions that it can allow access to (e.g. m4v). But then you will also need to amend the function above so it knows how to serve an m4v file. Add it like this:

    // Build an array of types that SWF Tools can react to
    $mime_types = array(
      'swf'  => 'application/x-shockwave-flash',
      'flv'  => 'application/octet-stream',
      'xml'  => 'text/xml',
      'mp3'  => 'audio/mpeg',
      'jpg'  => 'image/jpeg',
      'jpeg' => 'image/jpeg',
      'png'  => 'image/gif',
      'm4v'  => 'video/x-m4v',
    );

Finally, and I'm guessing you've worked this out, SWF Tools doesn't know what to do with an m4v without some help, so you need to pass it the action 'swftools_flv_display' so it knows to send the video to the appropriate player.

So there's quite a lot to go through here! First to understand why you get an error report at a line that doesn't have a preg_match in it, and then you need to tweak the module to support m4v, if you haven't done so already.

Botched upgrade - so it's not just me that does them :-)

No problem - although SWF Tools is just a hobby for me I actually quite like the trouble shooting (my regular job is as an engineer so it must be in my nature).

FYI - I am just finishing an upgrade to the SWF Tools admin page so you will be able to extend the association of extensions with actions, and add new mime-types, without having to hack the module. So you'll be able to make the changes described above simply by editing a settings page. That'll be another feature request off the list.

Your timing is perfect. I am just about to commit the first part of the extension handling code to CVS. It will be available from the development snapshot later.

In the short term, don't worry about the assignment. Go to Administer > Site configuration > SWF Tools > File handling, and in the File handling section set "Default player for a series of mixed media files:" to JW4 or FP3. When SWF Tools doesn't recognise an extension it automatically gets passed to the "mixed media" handler as a fallback.

Once the package generates and you've installed it simply go to Administer > Site configuration > SWF Tools > File handling and open the new "Advanced settings" section. You can now explicitly associate m4v with video by adding the extension m4v to the list to associate with video.

There'll be another commit later (hopefully) to handle the mime-type stuff.

Changing this to fixed as the issue described is resolved by a re-installation of the module.

If I embed at the end of a text line using [swf file="abc.mp3"], the player always displays on the next line, how do I theme so that the player is embedded on the same line?

pls ignore, display:inline; solved my problem.