current workflow's dev tarball (2010.03.15) made a change to the variable holding the state's radios
therefore, for such version to work properly driven_workflow will require to be patched

Note that this change won't be committed until next workflow's release,
since currently the recommended release is workflow-6.x-1.4

Comments

arhak’s picture

Status: Active » Needs review
StatusFileSize
new1.74 KB
Takafumi’s picture

StatusFileSize
new24.86 KB

#1 patch works but has a bit of problem.
Please see screenshot.
You'll find that transition is shown in a number.

arhak’s picture

oops, forgot to update diff_render

PS: soon this patch will apply with some offset warnings, but it won't mind
in any case, if a reroll would be needed, just read the last proposed patch, it will be very easy to manually perform the changes

arhak’s picture

BTW, it's a nice opportunity for you to experiment one of the differences between having "live render" enabled or not
if you don't enable it, the comment shown in your screenshot @#2 will remain the same (the snapshot taken on comment creation time)
but if you enable "live render", then it won't matter that the comment was created when a bug on diff_render existed, since it will be re-evaluated on display time (which, after applying the new patch should be corrected)

nevertheless, after playing around, I would recommend to keep "live render" DISABLED, since it is an advanced feature with several implications

Takafumi’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new21.13 KB
new21.23 KB

I confirmed it works fine with #3 patch. Great!

Takafumi’s picture

StatusFileSize
new21.13 KB
new21.23 KB

Mmm.. It seems to me that attached screenshots are not accessible.

arhak’s picture

#6 great demonstration
those screenshots also have the "live render" error for old comment made with workflow-6.x-1.4
which is due to a form structure change

that's one of the reasons for not using "live render" unless the site stops being built once and for all
of course, that can be addressed with the feature "frozen per flag" which hasn't been committed yet (because it is not so essential, since "live render" is discouraged anyway)

arhak’s picture

workflow module released its version 6.x-1.5
so maybe it is time to get this committed
(after confirming it still applies)