Reviewed & tested by the community
Project:
Driven API
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
1 Apr 2010 at 18:54 UTC
Updated:
1 Nov 2010 at 03:29 UTC
Jump to comment: Most recent file
Comments
Comment #1
arhak commentedComment #2
Takafumi commented#1 patch works but has a bit of problem.
Please see screenshot.
You'll find that transition is shown in a number.
Comment #3
arhak commentedoops, forgot to update diff_render
PS: soon this patch will apply with some offset warnings, but it won't mind
in any case, if a reroll would be needed, just read the last proposed patch, it will be very easy to manually perform the changes
Comment #4
arhak commentedBTW, it's a nice opportunity for you to experiment one of the differences between having "live render" enabled or not
if you don't enable it, the comment shown in your screenshot @#2 will remain the same (the snapshot taken on comment creation time)
but if you enable "live render", then it won't matter that the comment was created when a bug on diff_render existed, since it will be re-evaluated on display time (which, after applying the new patch should be corrected)
nevertheless, after playing around, I would recommend to keep "live render" DISABLED, since it is an advanced feature with several implications
Comment #5
Takafumi commentedI confirmed it works fine with #3 patch. Great!
Comment #6
Takafumi commentedMmm.. It seems to me that attached screenshots are not accessible.
Comment #7
arhak commented#6 great demonstration
those screenshots also have the "live render" error for old comment made with workflow-6.x-1.4
which is due to a form structure change
that's one of the reasons for not using "live render" unless the site stops being built once and for all
of course, that can be addressed with the feature "frozen per flag" which hasn't been committed yet (because it is not so essential, since "live render" is discouraged anyway)
Comment #8
arhak commentedworkflow module released its version 6.x-1.5
so maybe it is time to get this committed
(after confirming it still applies)