Just wondering why there's an empty column to the right of the Driven properties when viewing a node... Is this for a pending feature or am I missing something?

Screenshot attached.

CommentFileSizeAuthor
empty-column.png17.02 KBBrentnauer

Comments

arhak’s picture

Title: Empty column? » Empty column on the right? (Open Atrium themes: submit buttons)
Component: User interface » Theming

I recall making a comment about it when introducing #740310: support Open Atrium themes (Tao and its sub-themes: Rubik, Ginkgo, etc), but right now I can't find it, probably it was through mail or chat
lets pick it up again:

that is the div corresponding to submit buttons provided by Open Atrium themes
what should I do about it?
A- leave it to be addressed by users to their likings (with the css approach they might prefer)
B- when OA support is selected, remove the right column as well (with css provided by cdriven) since there won't be any submit button for the embedded node_form

at the time I asked there was no complain about it
what would say?

arhak’s picture

BTW, for this to be addressed it has to be tested with and without some node's properties which fall into the right column (class="column-side"), e.g. published/sticky/promoted

IMO the class="buttons" should be removed (said @#1)
but the main question would be, what to do with those properties which should fall into the right column?
I can't tell in advance which contrib modules will add properties under column-main or column-side
1- honor the theming applied to node_form and leave each themer to address the differences when it is wrapped into an id=driven_node container
2- try to remove column-right if detected empty (with jQuery)
3- make column-right go bellow column-main, but that would be going against OA's themes

arhak’s picture

Title: Empty column on the right? (Open Atrium themes: submit buttons) » Empty column on the right? (Open Atrium themes)

re-titled

arhak’s picture

Title: Empty column on the right? (Open Atrium themes) » Empty column? (Open Atrium themes)
Status: Active » Postponed (maintainer needs more info)

second thought: this requires Open Atrium experts
not only themers' advise or individual solutions,
instead I would recommend opening a support request on OA's community
since the decision should be based on the styles applied AND how the node_form is built
(or can potentially be built by contrib modules)
otherwise (IMO) hiding elements might bring greater issues to other users without noticing it

column-main or column-right might be empty
what to do when one of the columns is empty due to access control taking everything out?
shouldn't that be addressed by OA to support traditional access control?

class=buttons has display:none for column-main
I guess because the form knows there are no buttons within it
isn't OA the one responsible of this?

class=buttons is visible for column-right
I guess because the form thinks there are submit/preview buttons
BUT they got #access=FALSE and therefore it shouldn't be visible
isn't OA the one responsible of this?

PS: there is always the option to include settings to deliberately tell cdriven to include certain css rules
for hiding buttons/column-right/column-main (note that column-main could be the empty one while column-right the one containing the driven properties)
but that would be burdening cdriven with stuff that can be achieved with other approaches (e.g. css_injector)

alternatively, consider that this might turn into a documentation issue guiding how to configure css_injector for such purposes
which should be provided by OA's users/themers/experts, since I'm not a regular user
I can only provide the hint of using css selector #driven_node_container to discriminate from regular node_form,
or expand theme support if other suggestions arise