PostgreSQL Patch [#760914]

Comment	File	Size	Author
#4	antispam.admin_.inc_.patch	1.75 KB	phaul
#3	antispam-pgsql.patch	1.26 KB	nileshgr
	antispam-pgsql.patch	1.26 KB	nileshgr

Comment #1

pixture commented 3 April 2010 at 22:36

I have never used PostgreSQL. I searched the Internet but it seems that PostgreSQL supports both IFNULL and COALESCE. I am wondering why COALESCE does not work. Can you explain what's wrong (end up with an error? or does not work as expected? or what?).

Thanks,

Log in or register to post comments

Comment #2

nileshgr commented 4 April 2010 at 01:37

Actually, in PostgreSQL, its not IFNULL. It was mistyped in the docs. Its NULLIF [1]

COALESCE does the same job.

[1] http://www.postgresql.org/docs/current/interactive/functions-conditional...

Log in or register to post comments

Comment #3

nileshgr commented 4 April 2010 at 01:57

Status	File	Size
new	antispam-pgsql.patch	1.26 KB

Hi, I read the patch. The diff arguments got reversed. Here's a clean new working patch.

Log in or register to post comments

Comment #4

phaul commented 4 April 2010 at 13:57

Status	File	Size
new	antispam.admin_.inc_.patch	1.75 KB

Also there is an error of missing column from GROUP BY:

query: SELECT MIN(date) AS oldest, MAX(date) AS latest FROM antispam_counter ORDER BY date DESC LIMIT 365 in /var/www/drupal-6.16/sites/all/modules/antispam/antispam.admin.inc on line 456.

pg_query(): Query failed: ERROR: column "antispam_counter.date" must appear in the GROUP BY clause or be used in an aggregate function LINE 1: ...AX(date) AS latest FROM antispam_counter ORDER BY date DESC ... ^ in /var/www/drupal-6.16/includes/database.pgsql.inc on line 139.

this patch remedies that as well.