I know this may seem minor to non-themers, but the biggest part of the title-as-field patches that was annoying the crap out of me was the fact that node.tpl's $title got renamed to $node_title. Using consistent variable names across templates makes learning theming easier.

Over in #571654: Revert node titles as fields the $node_title variable was not properly reverted, but I was asked to move the patch to another issue.

CommentFileSizeAuthor
#1 node-title-rollback-761616-1.patch3.82 KBjohnalbin

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Follow-up to revert node titles as fields; $node_title -> $title » Follow-up to revert node titles as fields; revert $node_title to $title
Status: Active » Needs review
StatusFileSize
new node-title-rollback-761616-1.patch3.82 KB

And here's the patch.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.