Hi,

I updated Nodewords (6.x-1.x-dev 2010-Apr-03 ) and now my site is broken displaying following error when visiting admin section :

Parse error: syntax error, unexpected '{' in /home/myacc/public_html/sites/all/modules/nodewords/nodewords_admin/nodewords_admin.install on line 13

Pls. suggest a fix quickly.

CommentFileSizeAuthor
#8 nodewords-6.x-1.x-dev.tar_.gz51.01 KBsrobert72

Comments

srobert72’s picture

srobert72 commented
Priority: Normal » Critical

Same error. All site down.
I know it's DEV release but how to help test it if it crashes all site ?

srobert72’s picture

srobert72 commented

Missing last parenthesis on line 13.
You can correct it in : sites/all/modules/nodewords/nodewords_admin/nodewords_admin.install

Just replace

  if (!variable_get('nodewords_admin_installed', FALSE) {

by

  if (!variable_get('nodewords_admin_installed', FALSE)) {

It fixes crash but not warnings when calling update.php :

warning: Cannot modify header information - headers already sent by (output started at /home/drupal/sites/all/modules/nodewords/nodewords_ui/nodewords_ui.install:1) in /home/drupal/includes/common.inc on line 148.

And blank page displayed after running update.php and click on "update" button.
Just this last page of update wizard is blank, with just one symbol "1" displayed.

deepesh’s picture

deepesh commented

Pls. update with a proper fix, the above code-hack does not let the database update and now mollom update is half-way completed without the db update.

mattcasey’s picture

mattcasey commented

ditto. if anyone needs the latest working dev before this update, send me a message.

dkruglyak’s picture

dkruglyak commented
Status: Active » Reviewed & tested by the community

Marking reviewed and tested for quickest commit... I have the same problem and the same fix.

srobert72’s picture

srobert72 commented
Status: Reviewed & tested by the community » Active

Still active and not reviewed.
We have no fix. Parenthesis fix only avoid to crash all site but it still blocks update process.

At the moment the only valid fix we have is to revert back to previous DEV tar.gz release ...

dkruglyak’s picture

dkruglyak commented

So have you actually reverted CVS code to the previous version? The dev release has an obvious PHP syntax error.

srobert72’s picture

srobert72 commented
StatusFileSize
new nodewords-6.x-1.x-dev.tar_.gz51.01 KB

At the moment the only valid fix on DEV release is to install previous DEV release before 2010-Apr-03 one.
It is DEV release from 2010-Mar-30. I attach it for those interested.

Anonymous’s picture

Anonymous (not verified) commented
Title: Site broken after Nodewords update ? » Syntax error on line 13
Status: Active » Fixed

The code to automatically enable the new modules have been removed.

deepesh’s picture

deepesh commented

Doesn't seem to fix the error, the latest update displays the same errors and blocks database update script !

srobert72’s picture

srobert72 commented
Title: Syntax error on line 13 » Site broken after Nodewords update
Status: Fixed » Active

Still active. And not just a simple syntax error...
Site is really broken.

OK it's DEV release but needs also as quality as other releases.

For all those concerned you can repare your site with my backup in #8.

Anonymous’s picture

Anonymous (not verified) commented
Title: Site broken after Nodewords update » Syntax error on line 13
Status: Active » Fixed

This issue report only described in detail the syntax error; for other errors please open a different issue report.

OK it's DEV release but needs also as quality as other releases.

A development snapshot is less than an alpha release, generally speaking; if you can find development snapshots that have code that can be considered equal to an official release, that is not true for all the projects.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.