Closed (fixed)
Project:
Content moderation
Version:
6.x-1.2
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Apr 2010 at 03:59 UTC
Updated:
18 Apr 2010 at 12:04 UTC
Jump to comment: Most recent file
Comments
Comment #1
eugenmayer commentedJust to better undestand you:
The node title is always used from the currently most recent revision, eventhough its not live. Not the live-title is used?
Comment #2
captainack commentedHello Eugen,
That's correct. The two line patch I've attached puts the node and node_revision tables back in sync.
Unfortunately, though, it doesn't solve my immediate problem with pathauto. The path still ends up being that of the not-live version... I haven't dug into pathauto to see how it works yet, so the only solutions I have in mind are very hackish (e.g. saving the original path, and updating it later by changing the module's weight).
I decided to push the pathauto part of it off for later, thinking maybe you had better ideas for a clean solution.
Thanks,
Al
Comment #3
captainack commentedMarking as "needs review", because the pathauto request and the table synchronization are probably two separate issues, and the patch at least addresses the node table issue.
I've opened up a new ticket at #762790: Better integration with other modules (like pathauto) for the pathauto issue I'm having, and my thoughts on how we can correct it.
Thanks,
Al
Comment #4
eugenmayer commentedThis will go into the next release (1.3)
Thank you a lot for the feedback and the contribution akhaef!
Comment #5
eugenmayer commentedif you like, http://github.com/EugenMayer/content_moderation its on github now. Fell free to start a push request and include the patch there :)
Comment #6
captainack commentedHi,
Created a github account, created a "fork" (silly nomenclature - it's basically a clone), made a branch for this patch (titled it after this d.o issue #), and submitted a pull request for that branch. Was this the best way to collaborate? Are there community guidelines somewhere for things like this (e.g. naming of the branches, etc)?
Thanks,
Al
Comment #7
eugenmayer commentedHey!
That is a great job. I integrated your changes and accepted your pull request!. Thanks
Comment #8
eugenmayer commentedWill be fixed in release 1.3
Comment #9
eugenmayer commentedComment #10
eugenmayer commentedComment #11
eugenmayer commented