Hi.

Upon creation of a new revision, if the title is modified, the node table takes the title of the new revision, even before it goes live.

This doesn't play well with things like e.g. pathauto (the path to the node can change before it gets promoted to live).

Best regards,
Al

note: I'm running with the experimental drafts patch. If this turns out related to that, sorry for the noise. I'll try to poke a little further when I find a little time.

Comments

eugenmayer’s picture

Just to better undestand you:

The node title is always used from the currently most recent revision, eventhough its not live. Not the live-title is used?

captainack’s picture

Status: Active » Needs work
StatusFileSize
new1023 bytes

Hello Eugen,

That's correct. The two line patch I've attached puts the node and node_revision tables back in sync.

Unfortunately, though, it doesn't solve my immediate problem with pathauto. The path still ends up being that of the not-live version... I haven't dug into pathauto to see how it works yet, so the only solutions I have in mind are very hackish (e.g. saving the original path, and updating it later by changing the module's weight).

I decided to push the pathauto part of it off for later, thinking maybe you had better ideas for a clean solution.

Thanks,
Al

captainack’s picture

Status: Needs work » Needs review

Marking as "needs review", because the pathauto request and the table synchronization are probably two separate issues, and the patch at least addresses the node table issue.

I've opened up a new ticket at #762790: Better integration with other modules (like pathauto) for the pathauto issue I'm having, and my thoughts on how we can correct it.

Thanks,
Al

eugenmayer’s picture

Priority: Normal » Critical

This will go into the next release (1.3)

Thank you a lot for the feedback and the contribution akhaef!

eugenmayer’s picture

if you like, http://github.com/EugenMayer/content_moderation its on github now. Fell free to start a push request and include the patch there :)

captainack’s picture

Hi,

Created a github account, created a "fork" (silly nomenclature - it's basically a clone), made a branch for this patch (titled it after this d.o issue #), and submitted a pull request for that branch. Was this the best way to collaborate? Are there community guidelines somewhere for things like this (e.g. naming of the branches, etc)?

Thanks,
Al

eugenmayer’s picture

Hey!

That is a great job. I integrated your changes and accepted your pull request!. Thanks

eugenmayer’s picture

Status: Needs review » Fixed

Will be fixed in release 1.3

eugenmayer’s picture

Status: Fixed » Closed (fixed)
eugenmayer’s picture

Status: Closed (fixed) » Fixed
eugenmayer’s picture

Status: Fixed » Closed (fixed)