Now that Drupal 7 color module allows more than 5 things to be colored, with our own custom labels, we can make more items in Bartik re-colorable.

This issue is for discussion what else to make colorable, and to implement the ability to do so.

CommentFileSizeAuthor
#10 bartik-footer-block-coloring-762462.patch7 KBSteven Merrill
#9 colorizefooter.patch6.96 KBjensimmons
#4 bartik_crazy-colors.png211.49 KBJeff Burnz
#4 bartik_colors_poc_v1.patch6.27 KBJeff Burnz

Comments

jensimmons’s picture

jensimmons commented
Title: Define more items of Bartik to make re-colorable » Define more items to be re-colorable
jacine’s picture

jacine
she/her
Location New York
commented

Ok, well we know you are doing the footer... Is there anything else that needs to be colorable? Headings would probably be a good candidate.

Jeff Burnz’s picture

Jeff Burnz commented

Fieldsets and Tables - these appear to be crucial, because in the current state if a user goes for a dark color scheme and sets the Text Color as white bad things happen.

I'm working on a patch now for both.

Jeff Burnz’s picture

Jeff Burnz commented
StatusFileSize
new bartik_colors_poc_v1.patch6.27 KB
new bartik_crazy-colors.png211.49 KB

I've been messing around with this for a couple of hours and decided to just dump out a patch to show you where I think we could go with this - after quite bit of playing there seems to be many things not re-colorable, which is kind of odd for a colorable theme.

Colors like node body text and field descriptions are not re-colorable at the moment - that is not so good given the user can choose a dark color scheme.

Heres a patch, its pretty wild and is really just an example, but I ask you to review it, apply and start setting up some crazy color schemes to see what I mean - I attach my crazy color scheme aslo...

This could be going way to far of course, and we just live with users being able to set unusable color schemes, after all Garland allows you to do that (white text on a white background is doable in Garland).

jensimmons’s picture

jensimmons commented

Yeah, I think what you are talking about Jeff is way beyond what we want Bartik to do. I get that perspective.... especially since you make crazy powerful awesome themes for people all the time! But I want to dial back the plan away from crazy drawings like the one you posted in comment #4. Thanks, but uh, let's keep things way more simple.

Here's what I'm thinking. Let's colorize the footer. And NOT the footer text, links, or lines..... yes, it will only work with dark colors. People can leave it dark grey / black. Or change it to say, dark blue or dark red. Yellow won't work. Light green won't work. If people want to go nuts they can a) dig into the CSS, or b) use another theme.

That's a good example of what I'm thinking all over. Keep stuff SIMPLE. The color module interface is a *terrible* place to have 29 things to color. Garland has 5. I'm thinking Bartik will have like 7 or 8. Maybe. It's just about having a few options. It's not about having every single thing in the theme be colored by magical robots. There's no way.

Bartik won't work light text on dark background. Ever. Unless someone makes a contrib theme like that.... :P

Jeff Burnz’s picture

Jeff Burnz commented

Lol, yeah, I'm with you on KISS, right on.

bleen’s picture

bleen commented

Let's colorize the footer.

just a note when implementing colorization of the footer, be sure to refer to #781572: Whitespace below the footer when there is not enough content on the page first so that short pages dont look wonky

jensimmons’s picture

jensimmons commented
Title: Define more items to be re-colorable » Make footer background and sidebar block borders colorable

I'm working on this. It's kicking my ass a bit. :(

Dang color module preview won't load revised style.css. It caches it? And keeps it no matter what I do? Cleared caches. Turned color module on and off. Switched themes. Still, color module preview is using CSS from hours ago. Any suggestions?

jensimmons’s picture

jensimmons commented
Status: Active » Needs work
StatusFileSize
new colorizefooter.patch6.96 KB
Steven Merrill’s picture

Steven Merrill commented
StatusFileSize
new bartik-footer-block-coloring-762462.patch7 KB

The attached patch makes border recoloring work for blocks and the footer recoloring work as well.

Steven Merrill’s picture

Steven Merrill commented
Status: Needs work » Needs review

Status change.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Re: mysterious caching. Color.module saves the palette colour list in a variable:

variable_get('color_' . $theme . '_palette'

(BTW: probably a WTF, predates the Drupal cache system -- someone please file a bug on color.module!)

It gets cleared when you submit the colour settings page; alternatively clear it with devel module or with a variable_del() in the PHP block :)

Patch works great. RTBC :)

bleen’s picture

bleen commented

patch in #10 works great for me

jacine’s picture

jacine
she/her
Location New York
commented
Status: Reviewed & tested by the community » Fixed

Committed patch in #10! Thanks :D

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.