I suggest to expose the {system} table to views, to allow much more flexible usage of this module.

Patch to follow.

CommentFileSizeAuthor
#7 enabled_modules--762678-7.patch9.24 KBjuliangb
#5 enabled_modules--762678-4.patch8.92 KBjuliangb
#2 enabled_modules.views_.inc_.txt4.15 KBjuliangb
#2 enabled_modules.views_default.inc_.txt4 KBjuliangb
#1 enabled_modules--762678-1.patch638 bytesjuliangb
#1 enabled_modules.views_.inc_.txt4.17 KBjuliangb

Comments

juliangb’s picture

juliangb commented
Status: Active » Needs review
StatusFileSize
new enabled_modules.views_.inc_.txt4.17 KB
new enabled_modules--762678-1.patch638 bytes

This is an initial patch, plus the enabled_modules.views.inc file (sorry, my version of cvs doesn't seem to like the -N argument).

It is fairly basic at the moment - the fields show, but filtering and things don't work properly yet.

It'd be good if the patch + at least a blank .views.inc file could be committed to make it easier to patch from here.

juliangb’s picture

juliangb commented
StatusFileSize
new enabled_modules.views_default.inc_.txt4 KB
new enabled_modules.views_.inc_.txt4.15 KB

Updated version of enabled_modules.views.inc, and a first basic view which shows enabled modules. Next step is to sort out the info field, as that is where a lot of the real information about projects is.

Also, unless it wasn't clear - anyone who wants to use these must rename the files so that they become .views.inc and .views_default.inc .

mlncn’s picture

mlncn commented

Looks good– i'm probably not going to have a free moment until after DrupalCon, so i have added you as a maintainer. Can you send me your e-mail address (can use http://drupal.org/user/64383 contact tab) and i'll send you the D7 code so you can make a branch and keep code going in both.

(Will you be making it way across the pond to DCSF?)

juliangb’s picture

juliangb commented

Committed patch, still working on the other files for now.

juliangb’s picture

juliangb commented
StatusFileSize
new enabled_modules--762678-4.patch8.92 KB

I've just committed the attached patch, which basically caches the 'info' field of the {system} table into it's own table with separate fields - this is so that it can be exposed to views properly, avoiding the problems with a serialized field.

mlncn’s picture

mlncn commented
Status: Needs review » Reviewed & tested by the community

I very much approve! Should never have been in a serialized array!

juliangb’s picture

juliangb commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new enabled_modules--762678-7.patch9.24 KB

Committed the .views.inc file. It may need a few tweaks and improvements, but the basics are all there.

Patch attached.

I will deal with default views in separate issues, therefore, this one is now fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.