Firstly, fantastic module - really great that you are expanding the dynamic side of Drupal and can't wait for the next release. Just thought it might be worth pointing out that For and Against scores are often split between Home and Away like this: http://news.bbc.co.uk/sport1/hi/football/eng_prem/table/default.stm

Comments

Alun’s picture

Alun commented

Hi, yeah that would be a good way of representing it. I'll have to look at adding that in the future, however that is gonna mess up all previous versions of leaguesite, because of the way the points are currently stored :-S this is a good example of why I have posted the warning on the front page of the project, as it is going to alter drastically before we reach a stable version.

On a separate note, you have assigned this to yourself, does that mean you wish to fix the problem, or did you misunderstand the point of the assigned box?
Thanks
Alun

theo38’s picture

theo38 commented
Assigned: theo38 » Unassigned

Sorry misunderstood that and have unassigned. I would, like to help you with this, but I don't know how to make a module yet. Any pointers/tutorials u would particularly recommend. One thing I really like is the way that you have added a page devoted to the leagues and the results/standings, but I'm hoping u'll make it possible to fully customise and create that for yourself in views - particulalry as u'd then be able to display blocks of different leagues. The other thing I was thinking is that if u had a match and both teams decided to post the result independently u might end up w duplicate results, so it would be wise to prevent this. - just a thought...

Alun’s picture

Alun commented
Status: Active » Postponed

Well the best way to get started is to get involved in developing a module! Background in PHP is always good though! There are good tutorials on Drupal.
The league table is create-able in views already. I just need to add some pre-packaged views with the module. But with a bit of time you can do this already.
If two teams decide to post the result, then the second team to post it should see that the first team has already posted the result, and therefore not need to post it. Two independent users trying to alter the same node should be stopped by Drupals system, so I don't think it will be an issue.

I will postpone this issue for the moment, which means I do intend to implement away/home points separation, but I won't do it at the moment!

theo38’s picture

theo38 commented

Personally I think it's always best to assume nothing of the user when dealing with dynamic sites - i.e. you never know for sure that they will always check. You could simply query the database for duplicates by seeing if there already exists a match/result between the two teams on the date they have specified (not datetime as there is likely to be slight variation in the time) and return an error to them upon their attempt to submit the form. Afterall you might even accidentally post the same match/result more than once yourself...

theo38’s picture

theo38 commented

Oh I am sorry - I've just seen how you are administering this now and that it will be obvious if/when duplicate matches occur. Still, it might not be such a bad idea to prevent duplicates from occurring from the server/database side...

Alun’s picture

Alun commented

Cool, I plan to get a similar administration menu to create matches, so a large number of games could be created at once. I like the idea of the module warning you if you try to create two games with the same team setup on the same day though, it could be worthwhile..

Alun’s picture

Alun commented
Status: Postponed » Active

I'm working on this for the next dev update.

Alun’s picture

Alun commented

I have implemented this, but have yet to commit it. I hope it doesn't cause too much disruption. Hopefully those people using development releases of Leaguesite will be backing up their databases before updating, so if they are not happy, they can revert to the older version. I'll commit soon, probably at the end of the week.

Alun’s picture

Alun commented
Status: Active » Fixed

Might need some work, but this is now in the latest dev release.
Please backup before updating.
Thanks
Alun

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.