FB Connect and multiple domains

Hi Dave,

Actually - that's not the issue, and that only solves part of the problem. The issue is that many of the affiliates have completely different domain names. What this means is that we need to have one facebook app for each of those (the ones that share our base domain name could of course use the same facebook app).

This means that there would need to be some kind of mechanism within Drupal for Facebook that allows us to map facebook apps to domains. I'm picturing a list of domains on the left and a pulldown menu next to each one that lets you choose the facebook app that that domain will connect with. It seems like that functionality might already be there to some degree, since you can choose a primary app for facebook connect, and that this might not be a huge addition in terms of coding. no?

-perry

Hi Dave,

I don't really have the programming skills to do this, at least not without so much guidance that it might be easier for someone else to do it. but I can definitely spec out exactly how I think this would best work in a multi-domain environment, if that helps you to code it up faster.

Other than that I can try to muddle through, but I don't really know where to start.

Ok, i've been screwing with this all day and I think I have my head wrapped around what I need to do. Can you confirm that I'm on the right track here?

I'm making a contrib module to handle this, called fb_domain

1) set up the admin interface so that you can specify domain/fb app mappings if the domain module is installed. (this part is done, i've got the UI basically working).

2) in fb_connect.module, modify fb_connect_get_app() to:
a) Check for the existence of the domain module, and if there find the current domain
b) find the fb app that's associated with that domain
c) call _fb_connect_set_app(), passing it the $fb_app that we want

I *think* that's basically all I need to do to make it go, right? fb_connect_get_app() seems like the right function to do this in, but if not, let me know. I'm not 100% there yet, but very close. I just want to make sure I'm heading in the right direction with this.

thanks. very helpful, and a lot simpler than the way i was doing it!

Personally, i have no problem with filling out multiple forms on both FB and drupal. We had pretty much expected that that would be the case for this setup anyway, before we ever even installed Drupal for Facebook. At least in our case, many of the affiliate sites will use the same base domain, so the only time new apps need to be created is when an affiliate has its own domain, and there's not a lot of that with our setup.

OK, I think I'm really close on this now. I've got the Facebook Connect admin form set up with two fieldsets. Each one contains a list of domains, and a pulldown menu of fb apps. One is for mapping fb apps to domains, and one is for login buttons. These work, you can set the preference and they all stick. so that's that.

The issue I'm having now is that the login button will only appear on the login form if you set a primary connect application in the Facebook Connect admin settings form. However, that setting seems to be overriding the preferences set from the admin UI. below is my fb_domain module. If anything jumps out as being totally wrong here, please let me know. (one thing I haven't resolved yet is adding a "" option on the pulldown menus. Using your method from elsewhere in the module results in an array key of "0" which can also be a domain ID. Still trying to figure out how I'd deal with that.

/**
 * @file
 * 
 * fb_domain allows you to use Drupal for Facebook with the Domain Access
 * module. 
 *
 * This module modifies the Facebook Connect  admin UI to map facebook apps to
 * domains. If all of your affiliate domains are one one base domain, then
 * you don't need this. But if your affiliates have completely different
 * domain names, you'll need to use this to specify which facebook app 
 * should be used for each domain. Note that you will need to create a new
 * Facebook app for each unique domain you have, and you'll need to set those
 * up through the normal Drupal for Facebook "add application" screen.
 *
 */

define('FB_DOMAIN_MAPPING', 'fb_domain_mapping');
define('FB_DOMAIN_MAPPING_LOGIN', 'fb_domain_mapping_login');

/**
 * Implementation of hook_form_alter().
 * 
 * Add Domain Access settings to the admin form
 * and modify the user login forms to show domain-specific login buttons
 */
function fb_domain_form_alter(&$form, &$form_state, $form_id) {
	if($form_id == "fb_connect_admin_settings"){
		//get a list of all the affiliate domains
		$domains = domain_domains();

		//get a list of all the fb apps
		$fb_apps = fb_admin_get_app_options();

		//put it in a fieldset
		$form['fb_domain_mapping'] = array(
			'#type' => 'fieldset',
			'#title' => t('Domain/FB App Mappings'),
			'#description' => t("For each domain, choose a Facebook App to use for each affiliate domain. If you don't set this, FB connect may not work properly on some domains."),
			'#tree' => TRUE,
		);
		$form['fb_domain_mapping_login'] = array(
			'#type' => 'fieldset',
			'#title' => t('Domain Login Button Mappings'),
			'#description' => t("For each domain, choose the appropriate facebook app to use for the login button on login forms."),
			'#tree' => TRUE,
		);
		$domain_mappings = variable_get(fb_domain_mapping, NULL);
		$domain_mappings_login = variable_get(fb_domain_mapping_login, NULL);

		//generate a select list of fb apps for each affiliate domain
		foreach($domains as $key){
			//dsm($key);
			//this is for the domain/fb app mapping
			$form['fb_domain_mapping'][$key['domain_id']] = array(
			  '#type' => 'select',
			  '#title' => $key['sitename'],
			  '#options' => $fb_apps,
			  '#description' => $key['subdomain'],
			  '#default_value' => $domain_mappings[$key['domain_id']],
			);
			//this is for the login button mappings
			$form['fb_domain_mapping_login'][$key['domain_id']] = array(
			  '#type' => 'select',
			  '#title' => $key['sitename'],
			  '#options' => $fb_apps,
			  '#description' => $key['subdomain'],
			  '#default_value' => $domain_mappings_login[$key['domain_id']],
			);
		}

		//modify the #buttons weight to put them at the end of the form
		$form['buttons']['#weight'] = 10;
	}
	
	
	// Add a Domain-specific login button to login form.
	if (($form_id == 'user_login_block' || $form_id == 'user_login') && !fb_is_fbml_canvas()) {
	  
		//figure out what our current domain is
		$domain = domain_get_domain();
		
		//determine the facebook app to use for the login button	
		$domain_mappings = variable_get(fb_domain_mapping_login, NULL);
	  	
		if ($label = $domain_mappings[$domain['domain_id']]) {
		  $fb_app = fb_get_app($label);
		  
			// Ensure that facebook javascript is in the page closure.
			if ($fb = fb_connect_app_init($fb_app)) {
				fb_connect_require_feature('XFBML', $fb_app);
				fb_connect_init_option('ifUserConnected', "{FB_Connect.on_connected}", $fb_app);
				fb_connect_init_option('ifUserNotConnected', "{FB_Connect.on_not_connected}", $fb_app);
				
				// Add button to the form.
				$form['fb_connect_button'] = array(
				  '#type' => 'markup',
				  '#value' => '<fb:login-button v="2"><fb:intl>Connect with Facebook</fb:intl></fb:login-button>',
				  '#prefix' => '<div class="form-item" id="fb-connect-button">',
				  '#suffix' => '</div>',
				  '#weight' => 4, // LOG IN button weight is 2.
				);
			}		
		}
	}
}


function fb_domain_fb($op, $data, &$return){
  if ($op == FB_OP_CURRENT_APP && !$return) {
	//figure out what our current domain is
	$domain = domain_get_domain();
	
	//determine the facebook app to use for this domain	
	$domain_mappings = variable_get(fb_domain_mapping, NULL);
		
    if ($label = $domain_mappings[$domain['domain_id']]) {
      $return = fb_get_app($label);
    }
  }
}

Hi Dave,

Thanks - so what i'm seeing in the login form is this:

1) In the Facebook Connect admin UI, with a primary application set to "none" and a login button set to "none" i get no FB login button in the login form, even with my code.

2) If I set the Login button preference to one of the fb apps, but leave the primary application set to "none" I get the text "connect with facebook" where the login button should go, but it's not a button. just text.

3) if I set the login button to one of the fb apps and then set the primary application to the same one, I get the login button and I'm able to log in with facebook connect. However, if i go to one of the affiliate sites, it's attempting to use the fb app from the other affiliate, and that's causing facebook to display an error that the connect urls don't match up.

I have seen some suspicious URL errors in some cases, but what I am getting a lot of is this:

URL starts with fb_cb/[appname]. This should never happen on connect pages. Did the previous page have a badly formed link?

...where "[appname]" is the name of the currently selected primary facebook app

-perry

ok, so i realized that I hadn't completely copy/pasted your code from fb_connect.module. I've corrected that so that mine now looks like this:

	// Add button to login form.
	if (($form_id == 'user_login_block' || $form_id == 'user_login') && !fb_is_fbml_canvas()) {
		//figure out what our current domain is
		$domain = domain_get_domain();
		
		//determine the facebook app to use for the login button	
		$domain_mappings = variable_get(fb_domain_mapping_login, NULL);

		if ($app_label = $domain_mappings[$domain['domain_id']]) {
			$fb_app = fb_get_app(array('label' => $app_label));
			
			// Ensure that facebook javascript is in the page closure.
			if ($fb = fb_connect_app_init($fb_app)) {
				fb_connect_require_feature('XFBML', $fb_app);
				fb_connect_init_option('ifUserConnected', "{FB_Connect.on_connected}", $fb_app);
				fb_connect_init_option('ifUserNotConnected', "{FB_Connect.on_not_connected}", $fb_app);
				
				// Add button to the form.
				$form['fb_connect_button'] = array(
					'#type' => 'markup',
					'#value' => '<fb:login-button v="2"><fb:intl>Connect with Facebook</fb:intl></fb:login-button>',
					'#prefix' => '<div class="form-item" id="fb-connect-button">',
					'#suffix' => '</div>',
					'#weight' => 4, // LOG IN button weight is 2.
				);
			}
		dsm($form);
		}
		if ($form_id == 'user_login') {
			// On login, we must leave the user/login page or else get access denied.
			drupal_add_js(array('fb_connect' => array('destination' => url('user'))), 'setting');
		}
	}
	

lo and behold, now I get the "Connect with Facebook" text in the login form, when both the Primary app and the login form are set to "none". So, some progress, I think. Unfortunately, it's still not a clickable button.

I'm stumped. if I dsm() the $form variable (as you see in the code above), I can see that all the right stuff appears to be there.

#fb_connect_button (Array, 5 elements)
    *      #type (String, 6 characters ) markup
    *      #value (String, 81 characters )
             <fb:login-button v="2"><fb:intl>Connect with Facebook</fb:intl></fb:login-button>
    *      #prefix (String, 46 characters ) <div class="form-item" id="fb-connect-button">
    *      #suffix (String, 6 characters ) </div>
    *      #weight (Integer) 4

So i guess it's a javascript thing. Is it possible that by setting the login button to "none" in the Facebook Connect admin settings page, I'm no longer loading some critical javascript here? I can't seem to find anything, but that does seem plausible.

By the way, it does look like the following javascript files are loaded on the user/login page:

http://static.ak.connect.facebook.com/connect.php/en_US/js/Api/CanvasUti...

http://static.ak.connect.facebook.com/js/api_lib/v0.4/FeatureLoader.js.php

and then this inline script:

  $(document).ready(function() {
    FB_RequireFeatures(["XFBML"], function () {

      //FB.FBDebug.logLevel = 4;
      //FB.FBDebug.isEnabled = true;

      FB.XFBML.Host.autoParseDomTree = false;

      FB.init("333c2bfe9f3c9c1168c876781aee0a57", "http://staging.MYDOMAINNAME.com/fb_cb/MYAPPNAME/fb_connect/receiver", {"ifUserConnected":FB_Connect.on_connected,"ifUserNotConnected":FB_Connect.on_not_connected});
    });
  });

  FB.ensureInit(function()
    {
      FB_Connect.init();
      
    });

I'm seeing this is on both firefox 3.5.9 (mac) ad Safari 3.2.3 (mac).

It happens both on user/login and in the lightbox 2 version of our login form. When I set a primary app in the Facebook Connect UI (just to test), the button renders on both browsers in both situations. Turning off the primary app gives me the unrendered button. weird.

(by the way, i'm getting facebook session errors when i click on drupalforfacebook.org): white screen with "Facebook API exception Session key invalid or no longer valid" followed by about 30 lines of debug code.

just a quick update - I installed the latest dev version, and I'm still seeing this issue of the non-rendered button.

Dave - would it help you to look at the actual development site? If so, let me know how I can contact you privately to get you the URL.

Hi Dave,

Just wondering if you have any other ideas for what we might need to do to get this working. I'm out of ideas, but I feel like we're almost there with this.

Thanks!

won't be at drupalcon. I'll try to slog through this as best I can. if I can get a clean setup of drupal on another dev server going maybe I can isolate the issue. If anything springs to mind in the mean time, let me know!

We're trying to get this implemented in the next couple of weeks so the more time we have to test it before we push our next update to the live site, the better.

Upgraded from the dev version from last week to beta 11 this morning. Progress - we're now seeing the Connect with Facebook button on user/login. However, we also offer a Lightbox2 version of the login form. I did see the facebook connect button there once, but on subsequent tries (without changing any settings), it's not there. It seems to be there consistently for the form at user/login

So, something changed, but I really don't know what, to make this work for us. huh.

Still trying to debug the multiple domain stuff though, but at least I can test it now!

We've put this on hold for now, so if someone wants to take a stab at it, please do. Unfortunately, we need to get other stuff done by the middle of May, and with the impending changes to FBConnect from Facebook, it just made sense for us to put this off until that stuff is implemented.