Closed (fixed)
Project:
Subscriptions
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
31 Jul 2006 at 22:35 UTC
Updated:
30 Dec 2007 at 02:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
RyanR commentedI was just about to enter a feature request for this same topic. In other sites I have used where I subscribe to hear about updates, I would only be told about an update to a topic once until I visit the site again (or the topic). This way I'm not bombarded with loads of emails every time a change is made, even if I haven't had a chance to visit the site.
Comment #2
mattev commentedI agree. I was recently heavily spammed with comments to a few threads (now resolved) but subscriptions sent out a new notification for each spam message resulting in some users getting 20 or more notifications. Come to think of it, it would be nice if comments that were unpublished by the spam module did not result in a notification until they were approved and published by an admin.
Comment #3
johnhanley commentedI actually have this working in version 4.6. I simply check the number of new comments for each subscriber (user) and send a notification if equal to 1. In the notification message the user is informed that they must visit the thread before receiving another notification for that particular thread (and effectively keeps them subscribed.) Note that this solution only works when notification is set to immediate. Cron notifications would need further development.
Comment #4
ricmadeira commentedYeah, this feature would be great to have!
Comment #5
davidteall commentedIs this feature going to be added to the 4.7 version or can I use the 4.6 version on 4.7? I'm about to disable the module because I'm getting so many multiple notifications. My site is for a UK-wide club divided into Regions. Each region has its own pages updated by a Regional Editor. If the editor has 20 goes at updating a page because he is not quite sure how to do it, members ger 20 notifications and then write to me to complain!
Comment #6
ricmadeira commentedYeah, receiving notifications for each editing of a node is a real pain in the neck. :(
I think at least that problem can be solved more easily.
Comment #7
davidteall commentedOne further point, having re-read the opening Description. Most of my site uses pages with each region having their own taxonomy term. I therefore use subscriptions almost exclusively via what it calls categories. I need it restricted to one notification per category (not thread) until a page in that category is visted.
Comment #8
ajwwong commentedWith credit due to *BacteriaMan*, here's a patch against the latest 4.7 that does what the original poster requests... **only one subscription notification** is sent until the node has been visited [with the user logged in].... Thanks BacMan for the hard work!
[Incidentally... apparently it only works if notifications are set to "immediate"... rather than by cron]
Good luck all! Feel free to review! :-)
And Blessings,
Albert
Comment #9
salvisCould this be an option? I'm working in the opposite direction: to include body text in the message so that people who only want to read a forum need not to visit the site at all. Of course my way works better for low volume forums and I understand both needs, so body text should also be an option, I guess.
Comment #10
davidteall commentedThat would be an excellent addition and, yes, it would need to be an Option. It is already available in Notify so maybe there is some code there that would be helpful.
Comment #11
davidteall commentedVery many thanks ajwwong, but how do I use it? I guess I need to paste all or some of it into the original subscriptions.module file, but where do I put it and do I put every line? Sorry to be so ignorant, but there it is - I am!
Comment #12
ilbeppe commentedWhen this feature for drupal 5?
Comment #13
mindless commentedHere is the same patch for the drupal 5.x version.
(neither this nor the 4.7.x patch are ready for CVS because it would need to be optional..)
Comment #14
geodaniel commentedI like the sound of this patch, haven't had a chance to test it out yet though
Comment #15
Anonymous (not verified) commentedI tried the patch on Drupal 5, but it lead to the whole site freezing (PHP error in the script) - I'd love to see a workable patch for Drupal 5.1!
Comment #16
Anonymous (not verified) commentedHas anyone else managed to get the patch working on Drupal 5.x? I get more and more complaints from my users as the get swamped with announcements and having this patch would be a tremendous help!
Comment #17
mindless commentedanything in your watchdog log? i never tried it out, but the patch looks ok to me.
Comment #18
Anonymous (not verified) commentedI do not have watchdog installed, so the only thing I can tell you is I updated to the patched module and the whole site froze. There was a PHP error in the module (interestingly though in a line that was not in the module - it was something like error in line 1589 when the module only had 1570 lines)...
Comment #19
Anonymous (not verified) commentedEncouraged by mindless's comment I downloaded the fresh module and the patch again, applied and tested it - and so far it has neither crashed my site nor sent out numerous emails where one would have been enough. I will continue to test it, but so far it looks fine to me and should definitely be included in the module soon!
Comment #20
salvisI'm sorry, this would have to start from scratch, because version 5.x-2.0 was started from scratch (now in beta test).