Persistent login shows the "Remember me" checkbox on the user registration form when logintoboggan is installed.

This is desired behavior if logintoboggan's "Immediate login" setting is enabled but doesn't apply if "Immediate login" is not enabled.

Attached patch checks whether logintoboggan is enabled and if so, only displays the "Remember me" checkbox if "Immediate login" is enabled.

CommentFileSizeAuthor
#8 hide-remember-me-with-logintoboggan-integration-765116-8.patch1.19 KBchrisarusso
#7 persistent_login.module.patch776 bytespawel_r
persistent_login.logintoboggan.patch1.18 KBsetvik

Comments

markus_petrux’s picture

markus_petrux commented
Status: Needs review » Needs work

Thanks for working on this.

Here's a few comments about the patch:

- What happens when LT (logintoboggan) is enabled with the other conditions related to core user module settings? ie. when an administrator creates a user? E-mail verification required? ...
- Checking for existence of LT should be done just once.
- The comments in the code would have to be updated.

joostvdl’s picture

joostvdl commented

subscribing

YK85’s picture

YK85 commented

subscribing

robby.smith’s picture

robby.smith commented

I would like to learn more of the possible benefit of this as I use Logintoboggan module
subscribing

YK85’s picture

YK85 commented

I'm not seeing the Remember me checkbox at the User Register page.
I do see it on the User Login page. Is this something to do with my settings?

rokr’s picture

rokr
Location Bochum, Germany
commented

Subscribing.

pawel_r’s picture

pawel_r commented
StatusFileSize
new persistent_login.module.patch776 bytes

The same functionality patch but more "straight forward" - original conditions are preserved, module existence checked only once.

chrisarusso’s picture

chrisarusso commented
Issue summary: View changes
StatusFileSize
new hide-remember-me-with-logintoboggan-integration-765116-8.patch1.19 KB

I've got the D7 patch built off of @pawel_r 's previously applied patch for D6

chrisarusso’s picture

chrisarusso commented
Version: 6.x-1.4 » 7.x-1.x-dev
Status: Needs work » Needs review

  • gapple committed 8e9c6c7 on 7.x-1.x 
    Issue #765116 by gapple, pawel_r, setvik: Integration with logintoboggan...
gapple’s picture

gapple
he/they
Primary language English
commented
Status: Needs review » Fixed

Fixed in 7.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.