Closed (fixed)
Project:
Views (for Drupal 7)
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Apr 2010 at 06:59 UTC
Updated:
4 Jul 2010 at 07:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
dawehnerThe thing is, headers are not always converted.
The code before:
sure converted is false, when no conversion happend, but this is on a new views3 view always the case, there is no need for a conversion.
So i moved it up one level. Perhaps it could be also moved up another level under if (!empty($this->options[$area])) {
Comment #2
Crell commentedI don't fully understand what you said, but I applied the patch and it fixed the issue for me. Leaving as needs review for now in case it needs sanity checking.
Comment #3
dagmarOk, it is working fine. I have tested it in a fresh drupal install and in a upgrade from views 2 to views 3.
Related to
Is the same result in a fresh install, but as is this patch works.
Comment #4
endiku commentedThanks, that did the trick for me as well. Wasn't able to add the global text area for Empty text in views3.
Which I needed because it seems an exposed filter that results in no matches was removing the entire view including the exposed form element, meaning no more ability to search. Empty text fixes that but I don't want to make a new issue out of it until I'm sure.
Comment #5
dagmar@endiku please fill a new issue with your problem. Explain better what is happening and export your view. Thanks.
Ok, this issue was commited http://drupal.org/cvs?commit=352156 I'm marking it as fixed.
Comment #6
bsorrells commentedI can confirm that views-765310.patch fixes my problem of not being able to add a header, footer, or empty text.
Comment #7
dawehnertststs, this commit message was wrong :) Hehe if it does not work, dagmar can be clamed :)
Comment #8
crutch commentedditto: I can confirm that views-765310.patch fixes my problem of not being able to add a header, footer, or empty text.
Comment #10
JGonzalez commentedPatch fixes problem, however, was this not commited to alpha3?
Comment #11
JGonzalez commentedComment #12
dawehnerIt was commited to the dev version.