adding additional fail safe to not compact-ify if field is non-existent

CommentFileSizeAuthor
#2 compact_forms-DRUPAL-6--1.missing-field.2.patch815 bytessun
compact_forms-HEAD.fix_fatal.patch2.39 KBchriscalip

Comments

mlncn’s picture

mlncn commented
Priority: Normal » Major
Status: Active » Reviewed & tested by the community

Tested against the latest dev. (Note that version 6.x-1.2 has the same problem, but this patch doesn't apply successfully.) This fixes this hard-to debug problem (this JavaScipt error does not say what file caused it, as far as i could tell), and resolves what was a critical issue on our site of killing all the JavaScript).

This needs to go in!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new compact_forms-DRUPAL-6--1.missing-field.2.patch815 bytes

Um, why so complex?

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

danny_joris’s picture

danny_joris commented

I had the same issue with the current stable issue. Switching to the dev version seems like it solved it for me.