here is a patch that fixes that...

CommentFileSizeAuthor
#9 ie8Dashboard.png22.55 KBaspilicious
#7 dashboardCss.patch1.7 KBaspilicious
#2 dashboard-rtl.png59.37 KBaspilicious
dashboard-rtl.patch2.03 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Active » Needs review
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
dashboard-rtl.png59.37 KB

Here is a screenshot

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

dashboard-rtl.patch queued for re-testing.

Jody Lynn’s picture

Jody Lynn
she/her
Primary language English
CreditAttribution: Jody Lynn commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Dries’s picture

Dries CreditAttribution: Dries commented

This patch no longer applies, it seems.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

I'm on it...

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
dashboardCss.patch1.7 KB

Reroll, nothing changed there was one line of css moved thats why it wouldn't accept...

Good to go :)

BTW: if we find an issue afterwards we can do a followup AND this patch only adds rtl css, so things only got better.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs review

We're post-7.0 now, so we need to know what browsers things were tested in before we make CSS changes. And at least one of those needs to be IE. :P

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
FileSize
ie8Dashboard.png22.55 KB

NOOOO! Please don't make me look sad....

1) we don't "change" anything, we only "add" rtl styling ==> this will only affect rtl users
2) I tested this in IE8 ==> screenshot

3) I can't test this in IE7 cause there isn't a seven rtl patch commited yet so it looks kinda crap there, nothing to do with this patch.
BUT WE ARE IN A DEADLOCK SO PLEASE DON'T WAIT FOR THAT PATCH CAUSE IT WAITS ON OTHER RTL PATCHES == DEADLOCK
(srry for the caps, just would like the spread the opinion of drupal rtl css patchers)
4) IE9 is kinda broken, but RTL support in IE9 beta is kinda poor for the moment So we don't know yet what to do. We have to follow this up and maybe (if needed) make a patch when IE9 is out.

Tested every browser I have: IE7-IE9, chrome, firefox, opera

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-dev » 8.x-dev
Issue tags: +Needs backport to D7
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs work 
+++ modules/dashboard/dashboard.css	9 Apr 2010 12:55:37 -0000
@@ -7,7 +7,7 @@
 #dashboard div#dashboard_main {
   width: 65%;

We usually use '-' (dash) and not '_' (underscore) for CSS classes. Not related to this patch but maybe something to investigate separately.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs work » Reviewed & tested by the community

Sorry, I did not mean to change the 'Status'.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x. Thanks!

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Issue tags: -Needs backport to D7

untagging

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.