Recursive path creationg by file_service.module

Setting to needs review for patch test. Also IM not sure if this is needed functionality so I wont commit this patch until heyrocker signs off on it.

Set to dev so the patch passes

Im smoking crack sorry, leaving as review until test passes.

Ok, just waiting on heyrocker for this now , hehe.

I'm a little torn on this, because I feel like our file.save functionality should work under the same assumptions that core does in order to reduce confusion. Gimme a day to think about it.

Precisely why I thought it best to talk to you about it. I feel like it should be working in core, and I was not able to replicate this as a bug, but I wrote the patch anyway just in case.

#4 has somes view changes in it as well which seems wrong

Patch re-roll

It looks like this has been fixed in Drupal 7: #515280: file_check_directory() should create recursively
and it has also been reported for Drupal 6: #180970: file_check_directory fails to make directories if the parent doesn't already exist

The patch in #13 works for me, but wouldn't it be cleaner to do

$full_path = '';
foreach (explode('/', $dir) as $path) {
  $full_path .= $path . '/';
  if (!file_check_directory($full_path, FILE_CREATE_DIRECTORY)) {
    return services_error(t("Could not create destination directory for file."));
  }
}

This is a core issue and should be fixed in core soon.