Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I have just upgraded from 5.22 to 6.16 (running under Mac OS X Snow Leopard) and got a lot of warnings on the semaphore and menu_router tables, like so:
user warning: Table 'bnupgrade.semaphore' doesn't exist query: SELECT expire, value FROM semaphore WHERE name = 'menu_rebuild' in /Users/me/Documents/WebSites/bn/includes/lock.inc on line 154.
and like so:
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') ORDER BY fit DESC LIMIT 0, 1' at line 1 query: SELECT path FROM menu_router WHERE path IN () ORDER BY fit DESC LIMIT 0, 1 in /Users/me/Documents/WebSites/bn/includes/menu.inc on line 2099.
This does not seem to be a critical problem, since further down in Update #6020 there is a "create table menu_router" which has run successfully, while #6054 has a "create table semaphore", also fine. So far the site looks ok so I am continuing with the upgrade, but it is disconcerting to get these errors just the same.
I have previously done an upgrade from 5.22 to 6.15 and don't remember getting these problems (though my memory may be playing tricks)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | fix-semaphore-upgrade-errors.patch | 2.85 KB | hunmonk |
Comments
Comment #1
joel_guesclin CreditAttribution: joel_guesclin commentedThis upgrade also seems to cause a problem with books which I have noted here. I find that upgrading from D5.22 to D6.15 seems to avoid both problems.
Comment #2
batigolixThis error is the same when upgrading from 5.22 to 6.17. I confirm Joel's solution: first upgrade 5.22 to 6.15. Then 6.15 tot 6.17. This resolves the problem with disappearing book structures as well.
Comment #3
eddified CreditAttribution: eddified commentedSame problems here, but I don't have the book module enabled. I suppose I'll try to upgrade to 6.15 first.
Comment #4
eddified CreditAttribution: eddified commentedUpgrading from 5.22 to 6.17, I had the problems mentioned above. I also can confirm joel_guesclin's solution: first upgrading to 6.15, and then to 6.17, avoids the problems shown here.
Comment #5
hunmonk CreditAttribution: hunmonk commentedwow, i can't believe this problem has existed for so long. still results in a scary wall of red errors when trying to upgrade from the latest 5.x.
attach patch fixes the issue by moving the creation of the semaphore table to update_fix_d6_requirements(), and having system_update_6054() check for the existence of the table before creating it. this should address the issue fully.
Comment #6
oadaeh CreditAttribution: oadaeh commentedI've tested the patch on a site I was having troubles with on upgrading (currently, 5.23 -> 6.19; previously earlier versions). The patch applies cleanly, and the upgrade works as expected (except for other unrelated issues). (And my book outline shows up correctly!)
Comment #7
asb CreditAttribution: asb commentedsub
Comment #8
mo6sub
Comment #10
Gábor HojtsyLooks great, committed, thanks.
Comment #11
asb CreditAttribution: asb commented#9: The last submitted patch, fix-semaphore-upgrade-errors.patch, failed testing.
#10: Looks great, committed, thanks.
???
Comment #13
jpl-2 CreditAttribution: jpl-2 commentedReopening. The patch from comment #5 applies cleanly, but it apparently doesn't work. Upgrading from 5.23 to 6.19 with the patch applied still produces this error (four times):
Comment #14
jpl-2 CreditAttribution: jpl-2 commentedClosing again. The false alarm was due to variable update_d6_requirements already having been set to 1 in the test database before I applied the patch. This rendered the update.php part of the patch ineffective.