Closed (won't fix)
Project:
Nodewords: D6 Meta Tags
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Apr 2010 at 14:38 UTC
Updated:
25 Sep 2020 at 14:55 UTC
Jump to comment: Most recent
Comments
Comment #1
Anonymous (not verified) commentedI cannot reproduce this. Whenever I set the default value, or I set the value for the custom page, I always get the value of that token replaced by its value.
Trying with the global tracker page, I get the following meta tags:
I will test it with a default view defined from the module Views, and see if that change anything.
Comment #2
locomo commentedstrange..
i tried out a couple of more things and noticed that even when explicitly specifying the canonical url in the custom meta tag section, the custom value is ignored
so on that same food-and-dining page i've entered "food-and-dining" in the canonical field. i've confirmed that it is saved in the database.. but when viewing the page source i see the same as above (should i open a new issue for this)
another thing i noticed is that i can't actually delete these custom page settings.. i click delete and get confirmation that "My configuration options have been saved" - but the entry is still in my list of custom pages and still in my database
lastly regarding tracker pages.. it gets even wierder.. the token is properly expanded on user tracker pages with URLs like (token IS expanded):
user/100/track/navigation
but not on node tracker pages with URLs like (token NOT expanded):
node/796/track
Comment #3
Anonymous (not verified) commentedThe problem was that the token replacement was tried even when the module was not able to understand the kind of visited page (for which
_nodewords_detect_type_and_id()returnsNODEWORDS_TYPE_NONE); in that case,node_replace_tokens()doesn't replace any tokens, and that was the reason the token was output.Then, the custom page listed as is for pages with a path matching , and ; the patterns can be extended to include other paths.
The code has been changed, and committed in the repository. Thanks for your report.
Comment #4
locomo commentedthanks for working on this so fast.. unfortunately something is still not working
this is what i'm still seeing on pages i've created with panels
any ideas?
Comment #5
Anonymous (not verified) commentedIt seems a problem related with view pages. I have the same problem with the front page view; for some reasons, tokens are not replaced, in such cases.
Comment #6
Anonymous (not verified) commentedFor the front page meta tags, the option must be enabled, or tokens are not replaced.
Comment #7
locomo commentedI've now got my front page tags displaying properly thanks to your clarification. But all other pages created with panels are still printing the tag itself rather than the value of the tag for description and keywords.
No pressure, but just wondering where this is on your list of priorities? I need to make a determination about which version to go with.
thanks!
Comment #8
Anonymous (not verified) commentedI marked #777510: Canonical URL for front-page is not assigning the Token Value as duplicate of this report.
To reply about the priority of this issue for me, this issue has the same importance for me as other issue had; the problem with this issue is that I cannot reproduce it.
Comment #9
locomo commentedDo you have panels installed? If you do I think you should be able to recreate this by creating a page with panels and then try to add custom meta tag settings for that page.
I'm really not seeing any sign that the custom pages meta tags is working
Comment #10
Anonymous (not verified) commentedTokens work for me, when there are no panels involved. It could be the problem is just that.
Comment #11
locomo commentedare you planning on supporting pages created with panels??
this is a crucial issue for me and I would imagine many users for this module.. there seem to be a lot of people having trouble with tokens not printing on custom pages
Comment #12
locomo commentedokay - this is very crude.. but could be the start of support for panels pages - its working for me right now with the current dev release
Comment #13
snorkers commentedI've got this problem on 6.x-1.12beta9 (which I'm assuming was taken from DEV on 18 Apr 10), but do not have Panels installed. I'm still getting an incorrect Canonical URL for any Views-generated pages: the token itself is becoming part of the URL (as mentioned earlier, outputs as
<link rel="canonical" href="http://www.example.com/%5Bmetatags-url-alias%5D" />).Only way round it at the moment is to manually create META tags in the 'Custom Pages Meta Tags' option.
Comment #14
1mundus commentedI'm experiencing the same problem with views on beta-12. I'm not using panels with the mentioned token. The problem is that I have hundreds of views and I can't manually add their canonicals.
Comment #15
Vuds commentedI can also confirm that (and I'm not using panels). Canonical URL is not working for Views pages neither for the front page in my website.
I'm using DEV from May/11.
Comment #16
twodThe change made in #3 (Which I assume is http://drupalcode.org/viewvc/drupal/contributions/modules/nodewords/node...) looks incorrect:
The code
was changed to
This will cause $bool to always be true as any type will be either "not none" or "not offline".
No page type will ever be "none" and "offline", as nodewords_detect_type_id() only sets one type.
Shouln't this be
If the page type is "none" or "offline", $bool will be false and Nodewords ignores that page.
This way, no default tags are added for /user, /guestbook /whaterver_else_that_is_not_a_known_page.
Comment #17
locomo commentedfor the specific case of a page generated by views i still can't get any meta tags to appear
the change in #16 helps a bit in that this no longer appears:
yay and thanks!
but with this fix, when i create a custom page for a views page meta tags still do not appear
Comment #18
Anonymous (not verified) commentedThe code was not correct as the meta tags were added even when the module was not able to understand the type of the viewed page (
NODEWORDS_TYPE_NONE) or when the site was offline (NODEWORDS_TYPE_OFFLINE); in those case, the condition$options['type'] != NODEWORDS_TYPE_NONE || $options['type'] != NODEWORDS_TYPE_OFFLINEis always true (NODEWORDS_TYPE_NONE <> NODEWORDS_TYPE_OFFLINE).I changed the code, and committed it in the development branch. Thanks to TwoD for the help.
Comment #19
locomo commentedCool - that solves part of the problem.
Any new ideas why the module can't "understand" that a page was created by views and to add meta tags when a custom page has been created?
Comment #20
Anonymous (not verified) commentedI am moving the report to the project that will handle meta tags tokens in the next official release of Nodewords.
Comment #21
Anonymous (not verified) commentedI have marked #817356: [metatags-description] not working as duplicate of this report.
Comment #22
Anonymous (not verified) commentedComment #23
jcisio commentedI don't have access to http://drupal.org/project/metatags_tokens project. Problem? Then I move to nodewords.module, as it seems all code is there. I'll move it back when it is published.
In 6.12b9 I don't have "Use front page meta tags" option as instructed in #6. Token is not replaced in my frontpage (which in turn is a Panels custom page).
Comment #24
modctek commentedsubscribing
Comment #25
damienmckennaThis now belongs to the v6.x-2.x codebase.
Comment #26
damienmckennaMarking all v2 issues as postponed while v1 is finished off.
Comment #27
damienmckennaUnfortunately this module is no longer supported, so I'm closing this issue.