'The version of markItUp could not be detected' error

Latest version I had was 1.1.5 and it was working fine.
1.1.6 and 1.1.7 have been released since and one of them moved the version info from markitup/markitup/readme.txt to markitup/CHANGELOG.md.
This patch makes our version check look for readme.txt and then CHANGELOG.md if it doesn't find it.
The version string itself has the same format and these are minor bugfix releases so further changes should not be required.
This patch was tested with 1.1.7.

If you're not familiar/compfortable with applying a patch you can edit line 51 of markitup.inc to read

$changelog = $editor['library path'] . '/../CHANGELOG.md';

Patch from #1 works just fine! Thanx.

This is a no-brainer. Can we please have an updated dev generated?

Create a file:
sites/all/libraries/markitup/markitup/readme.txt

with the versión content:

1.1.7

... a better title.

I tryed to apply the patch to wysiwyg 6.x-2.1

$ patch --verbose --dry-run -p0 <wysiwyg-markitup-1.1.7.patch 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: editors/markitup.inc
|===================================================================
|RCS file: /cvs/drupal-contrib/contributions/modules/wysiwyg/editors/markitup.inc,v
|retrieving revision 1.7.2.2
|diff -u -p -r1.7.2.2 markitup.inc
|--- editors/markitup.inc	2 Apr 2010 14:05:54 -0000	1.7.2.2
|+++ editors/markitup.inc	11 Apr 2010 15:06:36 -0000
--------------------------
Patching file editors/markitup.inc using Plan A...
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file editors/markitup.inc.rej
done

But the same command was succesful with 6.x-2.x-dev!

And the patch is working!

Good to hear it's working.
Patches are always made against -dev versions as stable releases aren't touched again, so the above patch rejection was expected.

I'll start committing things soon again and this one will be one of the first to get in.

Thanks for the good news!

Rename CHANGELOG.md -> readme.txt
Move readme.txt to subdirectory /markitup

+++ editors/markitup.inc	11 Apr 2010 15:06:36 -0000
@@ -50,7 +50,11 @@ function wysiwyg_markitup_editor() {
   $changelog = $editor['library path'] . '/readme.txt';
...
+    $changelog = $editor['library path'] . '/../CHANGELOG.md';

Hm. Not really happy about the relative path adjustment. I guess we need to change the library path instead to not point to the sub-directory.

Powered by Dreditor.

Easy solution for all 'future' versions.
Instead of patching WYSIWYG module its easy to make a sym link

cd sites/all/libraries/markitup/markitup
ln -s ../CHANGELOG.md readme.txt

cheers,

markitup.inc is found at

sites/all/modules/wysiwyg/editors/markitup.inc

Some servers do not allow symbolic links, it is not portable!

Rerolled to work with new library path, added comment to make path change it a bit more clear. Minor changes really... RTBC as basic fix is already approved.

Just noticed markItUP 1.1.8 is out. They've bumped their dependencies to jQuery 1.4, meaning markItUp 1.1.8+ will not work with D6, even with this patch. (jQuery Update module could potentially work around this, but it has no official release supporting jQuery 1.4 for D6 at this point.)

MarkItUp 1.1.7 and below should still work with D6 until #685060: Get ready for 1.4 is fixed.

Thanks! Looks good to me.

Committed to all branches!

Changes will soon be in -dev snapshots and then part of the next stable release.

Thank you all for testing, reviewing and commenting!

Sorry to open again, but I just installed 1.1.9 and got the same error. "Version Could not be detected", and drupal error console is throwing the error messages:

warning: fopen(sites/all/libraries/markitup/markitup/readme.txt) [function.fopen]: failed to open stream: No such file or directory in /path_to_dir/modules/wysiwyg/editors/markitup.inc on line 52.
warning: fgets(): supplied argument is not a valid stream resource in /path_to_dir/modules/wysiwyg/editors/markitup.inc on line 53.
warning: fclose(): supplied argument is not a valid stream resource in /path_to_dir/modules/wysiwyg/editors/markitup.inc on line 58.

I downloaded WYSIWIG module, and put the markItUp! script in "sites/all/libraries/markitup/" like the documentation says. I'd leave it along, but apparently, I'm not the only one getting the issue. See also http://drupal.org/node/933190.

Any suggestions? Thanks!

Did you download and update to Wysiwyg 2.x-dev, the latest development snapshot?

@jweedman, I solve this problem, you need to upload whole library, not only "markitup" folder. Enjoy ;-)

This shows up in 7.x-2.1 aswell. Did exactly like stated

Extract the archive and copy its contents into a new folder in the following location:
sites/all/libraries/markitup

So the actual library can be found at:
sites/all/libraries/markitup/markitup/jquery.markitup.js

jut to get

Error
markItUp (Download)	Not installed.
The version of markItUp could not be detected.

Please can you either fix it (i can see there are pathces attached though the issue is closed ?!) or state the required jquery.markitup.js version for it to work.

The last patch was committed, hence the 'fixed' status.

I tested with markItUp 1.1.12 today and it works fine when I extract the downloaded "latest.zip" and rename the folder from "latest" to "markitup", no other changes. Note that this will produce two nested folders named "markitup", which is intentional as that's how the editor is patched. The changelog in the outermost folder is used to detect the installed version, and the editor files are expected to be in the inner folder. If the changelog is missing, or they've switched to a different version string format, you'll get the "The version of markItUp could not be detected." message.

(Btw, we've got a patch to add editor-specific installation notes in another issue, I'll add a note here about only renaming the extracted folder when that gets in.)

Does that help?

Is this clear enough?

The note in #26 would've helped me a minute ago. Rerolled.

Sorry, last patch was against 7.x-2.x HEAD

Thanks! I would have committed this for D7 and D6 now but the repositories are currently under maintenance...

Committed to 7.x-2.x and 6.x-2.x for inclusion in the next releases. Dev snapshots will be updated within 12hours.
D6: 01effdd
D7: ee64524

Thanks again everyone!