As of HTML standard, it is invalid to have an anchor-name with a name="comment-$cid" and some other element like div id="comment-$cid". This is invalid because name and id share identical namespaces.
Much more invalid is it if two html elements have the same id: Advanced forum adds the div id="comment-$cid" even if there's already an identical a id="comment-$cid".
advf-forum-post.tpl.php

In comments, each comment has an a id="comment-$cid" which is created by comment.module prepending each post. Advanced forum adds the is for each comment.
See comment.module function theme_comment_view @1585.

Removing the id from the container div makes the comment content no more accessible based on cid as the css selector. I don't expect this was used in real world. The HTML will be valid then.

The problem is, that some old browsers don't support a id="". w3c suggests to add both id="" and name="" with the same values for compatibility in xhtml 1.0. However the name="" was invalidated with xhtml 1.1.
http://www.w3.org/TR/xhtml1/#C_8
http://www.w3.org/TR/xhtml1/#h-4.10
http://www.w3.org/TR/2008/REC-xhtml-modularization-20081008/abstract_mod...

http://www.w3.org/TR/REC-html40/struct/links.html

I'm not sure yet if Browsers like IE6, IE7, ... are capable of jumping to a id="" attributed link or if they still require name="" to be present. However this would be some comment.module issue and not advanced forum one.

It seems to me we should simply remove the comment-cid identifier in advf-forum-post.tpl.php

Comments

michelle’s picture

This was already fixed in 2.x. Since 2.x isn't getting done as fast as I'd hoped, I'm probably going to end up spending some more time on 1.x so I'll leave this active for now.

Michelle

patator’s picture

There is a similar problem.
At one site I use Advanced Forum module and theme of sea breeze for blog.
I found a bug - incompatibility. Commentaries themes sea breeze is assigned to the style of the Advanced Forum.
Like this http://patan.msk.ru/blog/spisok-literatury-v-ms-word-2007-v-sootvetstvii...
The blog's comment have id "forum-comments"

With version 6.x-2.0-alpha2 is no such problem. Thanks for the correction.

michelle’s picture

Status: Active » Fixed

Committed, finally. Thanks.

Michelle

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.