Show link at end of body text setting is always ignored

Hi,

I have exactly the same!
All my weblinks have just under the normal content the link displayed.
The link is also displayed within the visit: .. completely at the right site next to the login or register comment.

I have the link now 3 times in the body field..
see: http://www.gratis-informatie.nl/wintersport-accommodaties-les-arcs

Please help!
Thanks in advance,
greetings,
Martijn

Hi,

I started looking at the code myself. It seems this behaviour is hardcoded in links_weblink.module!
So I had to (*) out the following function, to NOT get the link put twice in my theme.

This function you have to (*)
/**
* Apply markup to the appended weblink
*/
function theme_links_weblink_append($link_markup) {
$output = '

• ' . $link_markup . '

';
return $output;
}

I hope this helps somebody else to.
Please respond, while the weblink module is a very powerfull module I think!

greetings,
Martijn

The error report is correct (and, in fact, there was another similar problem you hadn't noticed yet). However, the function where you changed the code isn't where the conditional logic belongs. So I can't accept the patch (but I *am* nonetheless grateful for the attempt), but I changed the code in the place where that conditional logic actually was supposed to be. :-)

The corrected code is committed to HEAD branch and DRUPAL-5--1-4 tag in CVS now. It should propagate to the download page on the next batch run of drupal.org, if I've done my CVS commits correctly.

Thanks for the bug report! The patch wasn't quite right, but the report was spot-on and much appreciated. Your report also led me to notice another minor bug that I had previously overlooked and no one else had reported yet. So the code got better two ways today. :-)

Kind regards,

Syscrusher

Post Scriptum: I marked this as "patch, ready to be committed" because I wanted to give you an opportunity to retest before I mark the issue "fixed". Please retest at your convenience, and feel free to mark this issue "fixed" if you concur that this revision fixes the bug you have reported.

Kind regards,

Syscrusher

Hi Syscrusher,

Thanks for your kind words, and I will be able to test on monday.
I am using drupal 4.7.5. So can you please also update the 4.7.5 (4.7.6 now :) branch?

Thanks in advance!

Greetings,
Martijn
www.gratis-informatie.nl

Hi Syschrusher,

I still can't see a 4.7.6 patch for this?
Please assist.

Thanks in advance,
greetings,
Martijn