Revert change to grid style that changed basic behavior

The problem seems to be that there are no <td></td> for the 2 empty columns of the row. I think there were some before the update?

This was a feature request. To get back the old behavior, you need this preprocess code:

  $view     = $vars['view'];
  $result   = $view->result;
  $options  = $view->style_plugin->options;
  $handler  = $view->style_plugin;

  $columns  = $options['columns'];

  $rows = array();

  if ($options['alignment'] == 'horizontal') {
    $row = array();
    $row_count = 0;
    foreach ($vars['rows'] as $count => $item) {
      $row[] = $item;
      $row_count++;
      if (($count + 1) % $columns == 0) {
        $rows[] = $row;
        $row = array();
        $row_count = 0;
      }
    }
    if ($row) {
      // Fill up the last line.
      for ($i = 0; $i < ($columns - $row_count); $i++) {
        $row[] = '';
      }
      $rows[] = $row;
    }
  }
  else {
    $num_rows = floor(count($vars['rows']) / $columns);
    // The remainders are the 'odd' columns that are slightly longer.
    $remainders = count($vars['rows']) % $columns;
    $row = 0;
    $col = 0;
    foreach ($vars['rows'] as $count => $item) {
      $rows[$row][$col] = $item;
      $row++;

      if (!$remainders && $row == $num_rows) {
        $row = 0;
        $col++;
      }
      else if ($remainders && $row == $num_rows + 1) {
        $row = 0;
        $col++;
        $remainders--;
      }
    }
    for ($i = 0; $i < count($rows[0]); $i++) {
      // This should be string so that's okay :)
      if (!isset($rows[count($rows) - 1][$i])) {
        $rows[count($rows) - 1][$i] = '';
      }
    }
  }
  $vars['rows'] = $rows;

Hmm? I thought the feature request was to *ensure* that we had tds? Because without the tds the grids look odd. :/

Maybe we need to make it a switch.

[20:24] <dereine> merlinofchaos: to http://drupal.org/node/768162
[20:24] <dereine> there was a feature request to fill up the tds, thats working fine
[20:24] <dereine> but there was a feature request to not fill it, when there is just one row

Perhaps this should be configurable?

It seems that the new patch
- does include empty <td></td> if there is more than one row
- does NOT include empty <td></td> if there is only one row

Having empty <td></td> makes it a lot easier to theme the grid view. And the <td></td> should not cause any problems (nothing that could not be hidden with css).

So they should be there even if the grid view has only one row... (my opinion)

So you want to make it configurable.

On earlier days views 2.0, for example, this feature didn't exist at all, the rows wasn't poluted

Hm. Ok, no, in that case the issue is that the behavior is inconsistent. Every row should always have a full column's worth of tds. Maybe that patch I committed was simply wrong.

I think it was a valid feature request. I think there are two different kind of use cases.

Perhaps, but feature requests that change basic behavior must be weighed carefully, lest this happen. I didn't understand clearly enough what was wrong, I somehow though the patch had an error when there was only one row.

We need better/more communication

What happened with this?
Is it going back to the old way (empty tds)?
If not, is there a way to get around this with CSS?

I, like a lot people, I guess, have a gallery of thumbnail photos laid out as a grid.
If there are fewer then a row's worth of thumbnails, they distribute themselves over the width of the table rather than lining up to the left the way I'd like.
Specifying fixed-layout and specifying percentage column widths in the td tags doesn't work to fix this.
Thanks

This needs to go back to the old way. Sorry for letting it drop. I'll deal with it this week.

Many thanks.

Here is a patch which reverts the default behavior and make it configurable. So by default all columns gets displayed

Update to minimal code style issue(whitespaces)

Committed. I, er, accidentally committed #13 though. What was the actual diff between #13 and #14? My eyes aren't picking it out.

In #13, line 17 of the patch introduced trailing whitespace, so now line 44 of plugins/views_plugin_style_grid.inc has trailing whitespace.