Compatibility with casetracker

screenshots?
you forgot them

Dang, those must have been lost on preview. Maybe this time works.

Not, that they matter much, the issue just got solved and casetrackers UI is fixed :)!

I left devel having weight=88, but if they got higher then probably this module should review if it is ok with that

Oh, on second look its not devel-module itself that has over 1000 weight, it's one of its submodules at "/devel/performance/performance.module".

I'm curious: why are you using casetracker and cdriven at the same time?
are you trying to use cdriven as a complement to some missing functionality of casetracker?
wouldn't be better to open a feature request to casetracker project?

Well, actually I could have survived with casetracker alone (but the client wanted a bit more). So yes, im trying to complement
some missing features of casetracker, that is having some cck fields being editable in comments.

I'm not seeing casetracker having cck support in comments anytime soon. The idea of being able to control almost all node properties in a comment seems to have great potential.
Especially in sites driven by uhm.. comments.

Besides, it seems you're developing this module very fast and making it support all kinds of modules ;)

So, to get to what fixed the problem. I modified the "fixtest"-code you suggested a bit: changed if ($form_id != 'comment_form') { ==> $form['#id'] != 'comment-form' and the proper path to the casetracker element (and added the theme hook).

The fixtest.module looks like this now:

function fixtest_form_alter(&$form, &$form_state, $form_id) {

if ($form['#id'] != 'comment-form') {
    return; // we only care about comment_form, but in a form_alter (which goes after form_FORMID_alter)
}
  
   // lets jump in without checking for cdriven nor casetracker
  // (i.e. if they aren't acting both on this comment_form other errors will show up, but this is just a test)
 
  if(isset($form['comment_driven'][COMMENT_DRIVEN__DISGUISE_PREFIX . 'casetracker']['#theme'])){
	$form['comment_driven'][COMMENT_DRIVEN__DISGUISE_PREFIX . 'casetracker']['#theme'] = 'fixtest_casetracker';
  }
  
}

/**
* Implementation of hook_theme().
*/
function fixtest_theme(){
  return array(
    'fixtest_casetracker' => array(
      'arguments' => array('element' => NULL),
    ),
  );
}

// remember to properly declare this theme function in the hook_theme AND clear the cache
function theme_fixtest_casetracker(&$element) {

  $element = _comment_driven_undisguise($element);
  // again, we are jumping in because we know casetracker will be there for this test
  return theme_casetracker_case_form_common($element);
}

Result => Great success! Casetracker looks now like it was without "comment_driven".

Thanks for working with me on this (and the Wysiwyg issue).

EDIT: edited copypaste madness. I'm too tired.

Changing status to "needs review". It's pretty close to "reviewed & tested by the community" too :)

A funny sidenote: CCK support for casetracker was actually in the works with "cckasetracker" (http://drupal.org/project/cckasetracker).

It seemed rather limited, and the project page says:

The development of this module will stop in favor of CCK comments module, as it has a similar functionality, with no dependencies.

.. and when you go to to "comment_cck" ( http://drupal.org/project/comment_cck ), the page says

This module is going to be abandoned. An upgrade path to the Comment Driven module is being investigated. If you consider to install Comment CCK on a new site, you should rather use Comment Driven.

So.. at least this project isn't being abandoned just yet ;)

Took me a while to start testing this patch (I'm supposed to do my thesis which is due soon :p).

It didn't seem to work: both casetracker and team_notifications UI:s were messed up.

I started fiddling around and found the reason: $element['#theme_used'] = true; . That is, Drupal thinks the form element theming is now handled and we're done with it, so it won't get themed after the undisguising. Or that's how I understand it. I tried setting that var to "false".. and both notifications_team and casetracker got rendered fine. Yay :). Probably would fix lots of other modules' output too?

Again, I only added this "$element['#theme_used'] = false;" to the theming function, which looks now like:

function theme_comment_driven_proxy($element) {
  // key #theme is expected to be overriden by its disguised version
  // but, just in case, lets ensure we won't fall back here (unintended recursion) 
  unset($element['#theme']);

  // Also need to set #theme_used to false, so drupal render doesnt get confused when it does the real theming
  $element['#theme_used'] = false;

  $element = _comment_driven_undisguise($element);
  return drupal_render($element);
}

Please try the attached patch (for alpha-2).

Patch in #12 works great for me! casetracker and team_notifications UI seem normal.

Currently I can't do further testing, I really have to concentrate on my thesis for a while. Luckily it's about Drupal ;)

I'm glad this is fixed and I could be of help :).