Session language switcher links do not report the active status correctly

This sounds like an issue to me that could happen quite frequently; i.e., not really tied to the session language negotiation.

Problem: The language switcher block does not highlight any language.

Goal: Always highlight the active/corresponding language in the language switcher block.

Details: (please correct me where I'm wrong)
- The currently active language is not highlighted, because the language switcher links only account for the negotiated URL language of the request.
- The URL language negotiation, and therefore the current URL, always dominates the representation of language switcher links, not respecting any other language negotiation (like session).
- Although no URL language was negotiated (and thus, no link is highlighted), a session language was negotiated.
- This seems to be caused by http://api.drupal.org/api/function/theme_links/7:

      if (isset($link['href']) && ($link['href'] == $_GET['q'] ...)
          && (empty($link['language']) || $link['language']->language == $language_url->language)) {
        $class[] = 'active';
      }

Am I missing something?

(errr, strange tags here)

The #1 patch works. I repeated steps 1-7 as listed by plach. I could only repeat the issue when I clicked on a note title listed on the home page. Once i applied the patch the home page listing link produced the correct language highlight in the language select box on the destination page.

Updating status.

#1: language_switcher-768240-1.patch queued for re-testing.

Committed to HEAD. Thanks!