I found a bug in todays locations.tpl.php v. 1.2.2.1
It has a 'dangling' </div>. This caused some strange things to happen to my zen-based theme.
A patch to fix it attached, it just moves </div> to before the closing curly bracket.
I have marked this as critical, I had to roll back on one site rather quickly and it took a while to track down the culprit.

CommentFileSizeAuthor
#2 locations.tpl_.php-bad-close-div.patch465 byteshutch

Comments

yesct’s picture

Issue tags: +Location theming

Hutch, the patch is missing...

hutch’s picture

StatusFileSize
new465 bytes

Ooops, here comes:

yesct’s picture

Status: Active » Needs review

thanks for all the location work!

yesct’s picture

hutch’s picture

Same bug I think, I couldn't find it ;-(

yesct’s picture

Hutch, could not find what? Oh, you mean the other issue when you were searching for your issue? :) Yeah, the location module issue queue is hard to dig through :) One of the things I'm trying to help with. :)

eporama’s picture

Status: Needs review » Reviewed & tested by the community

I applied this patch against 6.x-3.x-dev and tested with multiple locations. It does indeed fix the improper nesting of locations. And removes the dangling div if you don't have any locations at all.

Melissamcewen’s picture

I tested this on Justfood.org and it's working for me.

bdragon’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed. (I hope, had to do a bunch of stuff manually because DRUPAL-5--3 was a bit out of sync)
http://drupal.org/cvs?commit=356848
http://drupal.org/cvs?commit=356850
http://drupal.org/cvs?commit=356906

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

grasmash’s picture

Committed to what version? I'm using 6.x-3.x-dev and still experiencing this bug.

Exact same symptoms as in:
http://drupal.org/node/772146

*UPDATE*

This problems seems only to occur on nodes where at least 1 location is permitted, but no location information has been entered.

yesct’s picture

Status: Closed (fixed) » Active

madmatter23, thanks for following through on this.

Please confirm the date of the recent dev version you are using, and provide a step by step, starting with a blank test site, with how to reproduce this bug. That will really help others be able to test this out and help find a solution. Thanks.

podarok’s picture

Priority: Critical » Major

not critical

legolasbo’s picture

Issue summary: View changes
Status: Active » Closed (outdated)

Closing old D6 issues as D6 is end of life