Some of the core tables in the PostgreSQL schema are serials, but have their default as 0 instead of nextval(), which isn't really a problem due to the way Drupal gets the next ID to be used, but should be fixed for cleanliness' and consistency's sake -- most of the tables are set up to use serial numbers properly, but menu, node_revisions, and users aren't.

I'll be happy to submit a patch, but I'm going to wait until #76881 (PostgreSQL support for installer) gets committed, since I'll just have to redo the patch afterward anyway.

CommentFileSizeAuthor
#3 system.install.serial.patch1.66 KBSteve Simms

Comments

Steve Simms’s picture

Steve Simms commented
Component: database system » postgresql database
sammys’s picture

sammys commented

Installer support has been committed to HEAD. Please proceed with your patch.

Cheers,

--
Sammy Spets
Synerger
http://www.synerger.com

Steve Simms’s picture

Steve Simms commented
Status: Active » Needs review
StatusFileSize
new system.install.serial.patch1.66 KB

It looks like you already took care of the menu case, so this one covers the remaining two instances that had separate "create sequence" commands instead of defining the fields as serials. I followed your pattern of including the CHECK constraint.

sammys’s picture

sammys commented
Status: Needs review » Reviewed & tested by the community

hehe... it's funny that I overlooked something so obvious. I'll blame it on the late hour I was rolling up those patches :)

Patch works. Ready to be committed.

sammys’s picture

sammys commented

oh and thanks smsimms for submitting the patch!

dries’s picture

dries commented

Thanks folks! Committed to CVS HEAD.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)