Apparently someone from myevents.com is going around accusing Drupal users of trademark infringement because this module uses "MyEvents" as a page title. I have rolled a patch to address it. See attached for the 4.6 patch.

CommentFileSizeAuthor
#1 eventfinder_head.patch7.19 KBseanr
eventfinder_46.patch4.05 KBseanr

Comments

seanr’s picture

StatusFileSize
new7.19 KB

See attached for the patch for head.

seanr’s picture

BTW, marked as critical even though it doesn't affect the functionality of the module in any way due to the serious risk it puts end users in.

seanr’s picture

Version: 4.6.x-1.x-dev » master
Status: Needs review » Reviewed & tested by the community

Committed in DRUPAL-4-6 (thanks, Morbus), still needs to find it's way into HEAD.

seanr’s picture

Priority: Critical » Normal

Marking as normal, since HEAD apparently isn't ready for prime time yet anyway.

jeff@jzamrzla.net’s picture

Before you acquiesce to this demand, take a serious look at what Plone's Trademark conmmittee had to say about it http://comments.gmane.org/gmane.comp.web.zope.plone.user/44859

Jeff Zamrzla
Web Designs by JA Zamrzla llc

morbus iff’s picture

Discussion is moot - I've already done so. "MyEvents" is trademarked; "My Events" is not. "MyEvents" is, as seanr mentioned privately, an incredibly lame mash-up that was popular five years ago; "My Events" is not.

bradspangler’s picture

I recently installed CivicSpace 0.8.5 for a client and they just got one of these letters. Since the changelog indicates CivicSpace 0.8.5 has the patches from Drupal 4.6.8, I decided to try to apply the eventfinder_46.patch (assuming "46" refers to Drupal 4.6.x).

After examining the patch in a text editor, I saw that it gets applied to the files "eventfinder_themes.inc" and "eventfinder.module". I downloaded those two files from the host and put them in a temporary folder on my KDE (FC4) desktop. Opening a console in that folder, I attempted to apply the patch. Results follow:

[user@localhost eventfinder_download]$ patch -p0 < eventfinder_46.patch
(Stripping trailing CRs from patch.)
patching file eventfinder.module
Hunk #1 FAILED at 298.
Hunk #2 succeeded at 1829 (offset 683 lines).
Hunk #4 succeeded at 1860 (offset 683 lines).
1 out of 4 hunks FAILED -- saving rejects to file eventfinder.module.rej
(Stripping trailing CRs from patch.)
patching file eventfinder_themes.inc
Hunk #1 succeeded at 77 (offset 11 lines).
[user@localhost eventfinder_download]$

I'm not very familiar with using the patch command, but that looks like failure to me. Contents of "eventfinder.module.rej" follow:

***************
*** 298,304 ****
    $opts = array('Above Event Details', 'Below Event Details');
    $group = form_radios('Display EventFinder Options', 'ef_display_opts', variable_get('ef_display_opts', 1), $opts, 'Define where to place EventFinder options relative to the content of the event details.');
    $group .= form_textarea('Search Description', 'ef_search_desc', variable_get('ef_search_desc', ''), '100%', 3, 'Description for the main search interface.');
-   $group .= form_textarea('MyEvents Description', 'eventfinder_myevents_desc', variable_get('eventfinder_myevents_desc', ''), '100%', 3, 'Description for the MyEvents page.');
    $group .= form_textarea('Host an Event Description', 'eventfinder_host_desc', variable_get('eventfinder_host_desc', ''), '100%', 3, 'Description for the Host an Event page.');
    $group .= form_textarea('Send Message to Registered Users Description', 'ef_message_desc', variable_get('ef_message_desc', ''), '100%', 3, 'Description for the Send Message to Registered Users page.');
    $output .= form_group('Display Settings', $group);
--- 298,304 ----
    $opts = array('Above Event Details', 'Below Event Details');
    $group = form_radios('Display EventFinder Options', 'ef_display_opts', variable_get('ef_display_opts', 1), $opts, 'Define where to place EventFinder options relative to the content of the event details.');
    $group .= form_textarea('Search Description', 'ef_search_desc', variable_get('ef_search_desc', ''), '100%', 3, 'Description for the main search interface.');
+   $group .= form_textarea('My Events Description', 'eventfinder_myevents_desc', variable_get('eventfinder_myevents_desc', ''), '100%', 3, 'Description for the My Events page.');
    $group .= form_textarea('Host an Event Description', 'eventfinder_host_desc', variable_get('eventfinder_host_desc', ''), '100%', 3, 'Description for the Host an Event page.');
    $group .= form_textarea('Send Message to Registered Users Description', 'ef_message_desc', variable_get('ef_message_desc', ''), '100%', 3, 'Description for the Send Message to Registered Users page.');
    $output .= form_group('Display Settings', $group);

It's not clear to me whether this is an issue with the patch itself, my usage of the patch command or just a CivicSpace vs. Drupal thing.

Any help deeply appreciated.

morbus iff’s picture

You shouldn't need the patch - just download the current version of eventfinder for 4.6, and it should already be applied. This issue only remains open as a reminder to doublecheck the forthcoming 4.7 build.