When there's a feature that less than 1% of sites need, especially when it would negatively impact the other 99% of sites, rather than putting it in core, we try to allow contrib modules to account for it. This would allow those bidding for US government contracts to meet the needs of the NIST directive, and it would also allow people to use Damien's Drupal C extension to replace parts of common.inc
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 0001-Issue-769648-Make-common.inc-swappable.patch | 6.3 KB | marvil07 |
| #8 | variable_common_inc_8.patch | 1.65 KB | joshuajabbour |
| #5 | variable_common_inc_4.patch | 1.31 KB | joshuajabbour |
| #3 | variable_common_inc_3.patch | 1.31 KB | joshuajabbour |
| #1 | variable_common_inc.patch | 780 bytes | catch |
Comments
Comment #1
catchPatch.
Comment #2
catchmenu.inc is already swappable.
Comment #3
joshuajabbour commentedattached is a fix to the patch in #1 to remove the double slashes in the path. It also fixes the same problem in the menu.inc inclusion...
Comment #5
joshuajabbour commentedreroll
Comment #7
joshuajabbour commentedargh
Comment #8
joshuajabbour commentedok, one last try. no more git diff. silly testbot...
Comment #9
joshuajabbour commentedComment #10
catchComment #11
marvil07 commentedComment #12
moshe weitzman commentedIIRC, the very first versions of multi-site (circa 4.5) let you swap /includes files just like modules and themes. So, you would add a sites/all/includes folder and put your own common.inc there. Same for sites/foo/includes. Maybe we should go back to this.
This is a bit tricky for files that are needed before conf_path(), but we can probably find a settings.inc based solution for these.
Comment #13
valthebald#11: 0001-Issue-769648-Make-common.inc-swappable.patch queued for re-testing.
Comment #15
dawehnercommon.inc doesn't really exist anymore at that point in time.