When editing existing keywords (no taxonomy), we were unable to remove existing keywords (new keywords could be added without problems). I inspected the following file:

// $Id: biblio.keywords.inc,v 1.6.2.13 2009/11/09 21:29:02 rjerome Exp $

The problem is that "biblio_update_keywords" passes "TRUE" to "biblio_save_keywords". As a result, biblio_save_keywords does NOT remove existing keywords. If I change this to "FALSE", then editing works (and I can remove keywords).

While this simple change works for my site, I did not make sure that this does not cause unexpected side-effects (such as not merging keyword lists when importing). However, the function is only called from "biblio_update" which seems to be only used for user-driven edits and hence this should be fine.

Given the one-line change, I'm not attaching a diff.

Comments

rjerome’s picture

Status: Needs review » Fixed

Thanks for pointing that out.

I think the problem actually lies in the biblio_save_keywords function at line 114. Where it says

  if (!$update) ...

It should have been

  if ($update) ...

Ron.

http://drupal.org/cvs?commit=354188

Status: Fixed » Closed (fixed)
Issue tags: -patch, -Keywords, -editing

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +, +, +editing