Calls to setSummary() must be renamed to drupalSetSummary()

Oh wait. I just realized the Javascript code is in fact intended to toggle the visibility of the tab, much like it is supposed to do for the reordering table. It just doesn't work properly.

It also doesn't work fully in the reordering table, by the way - some of the filters are still listed even though they're inactive.

Update: The event that does this is in fact not attached to most of the filter checkboxes.

      $checkbox.bind('click.filterUpdate', function () {
        alert("Clicked");
        if ($checkbox.is(':checked')) {
          $row.show();
          if (tab) {
            tab.tabShow().updateSummary();
          }
        }
        else {
          alert("Hiding!");
          $row.hide();
          if (tab) {
            tab.tabHide().updateSummary();
          }
        }
        // Restripe table after toggling visibility of table row.
        Drupal.tableDrag['filter-order'].restripeTable();
      });

"Clicked" and "Hiding" will be displayed when unchecking the very first checkbox, "Limit allowed HTML tags", but neither are displayed on the rest.

The problem is caused by this snippet:

      // Attach summary for configurable filters (only for screen-readers).
      if (tab) {
        tab.fieldset.setSummary(function (tabContext) {
          return $checkbox.is(':checked') ? Drupal.t('Enabled') : Drupal.t('Disabled');
        });
      }

The function "setSummary" does not exist; execution terminates before any of the other elements get their event listeners attached.

This, in turn, is caused by #445130: Namespace the Drupal jQuery functions not being sufficiently reviewed, as the function renaming of setSummary to drupalSetSummary leaves four outdated calls in three modules: book, filter and comment. This patch fixes all four.

Updating title/component, also upgrading to critical since javascript execution is broken by this and it affects several modules.

This sleuthing is really more fun than it should be. (Unfortunately, I've now blown my Drupal time today on this. :/ )