When Drupal detects my timezone, it suggests Europe/Kaliningrad (GMT+3), though my timezone is Europe/Copenhagen (GMT+2).

The problem is that my browser (Firefox on Debian Lenny) uses the CET abbreviation during both summer and winter. It currently returns "Tue Apr 13 2010 20:37:20 GMT+0200 (CET)", though the official abbreviation during daylight saving time is CEST. Apparently, if the abbreviation is known to timezone_name_from_abbr(), the other parameters to the function are ignored.

In Google Chrome on the same OS it works fine.

I don't know how common this problem is. But here is a patch that makes timezone.js omit the time zone abbreviation if it is the same string with and without daylight saving time.

CommentFileSizeAuthor
#4 timezone-detect-4.patch2.85 KBsaurabh.tripathi.cs
timezone-detect-1.patch2.85 KBc960657

Comments

Danic’s picture

Danic commented
amontero’s picture

amontero
Location Barcelona
commented

timezone-detect-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, timezone-detect-1.patch, failed testing.

saurabh.tripathi.cs’s picture

saurabh.tripathi.cs commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new timezone-detect-4.patch2.85 KB

Hi,
I applied this patch again on drupal 7.51 tag and it works properly, uploading the same again.
Thanks

Status: Needs review » Needs work

The last submitted patch, 4: timezone-detect-4.patch, failed testing.

saurabh.tripathi.cs’s picture

saurabh.tripathi.cs commented
Status: Needs work » Needs review

It seems, The auto review is not changing directory while applying patch.

darius.restivan’s picture

darius.restivan commented
Status: Needs review » Reviewed & tested by the community

Patch 4 failed to apply.

dddave’s picture

dddave commented
Status: Reviewed & tested by the community » Needs review

#7 makes no sense. Setting status back.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.