The permissions application to view invalid domains seems broken. Also triggers index notices:
# Notice: Undefined variable: item in domain_invalid_domain_requested() (line 2196 of /Applications/MAMP/htdocs/drupal-cvs/sites/all/modules/domain/domain.module).
# Notice: Undefined variable: item in domain_invalid_domain_requested() (line 2197 of /Applications/MAMP/htdocs/drupal-cvs/sites/all/modules/domain/domain.module).
# Notice: Undefined property: stdClass::$name in domain_invalid_domain_requested() (line 2202 of /Applications/MAMP/htdocs/drupal-cvs/sites/all/modules/domain/domain.module).
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | domain-771108-8-fix-php-notices.patch | 1.55 KB | mikeytown2 |
| #3 | 771108-username-index.patch | 824 bytes | agentrickard |
Comments
Comment #1
agentrickardSeems to be working now. Perhaps an issue with Drupal CVS.
Comment #2
karnal69 commentedHi,
I'm coming across the Undefined property error:
Notice: Undefined property: stdClass::$name in domain_invalid_domain_requested() (line 2495 of C:\wamp\www\optimal-power-solutions.com\sites\all\modules\domain\domain.module).But only on one of my 4 domains. Also, it only occurs when I'm viewing the site as an anonymous user.
My domain structure is:
mydomain.com
staging.mydomain.com
subdomain.mydomain.com
staging.subdomain.mydomain.com
mydomain.com and subdomain.mydomain.com are active, while the two staging domains are inactive. Everything is fine logged in as user1 (I have Enforce Rules on Administrators set to on), and I can traverse all 4 domains. When logging out and viewing the sites anonymously, the two staging domains are not available (as expected), and mydomain.com is working fine. But when viewing subdomain.mydomain.com, I get the above error on every page except . However, if I click a 'Home' link in my menu that takes me to the front page, I get the error.
So essentially subdomain.mydomain.com does not produce the error, but subdomain.mydomain.com/node/* does.
As far as I can see there's nothing special about this domain configuration.
K.
Comment #3
agentrickardI still can't replicate this, possibly because I have caching turned on. But we did miss an isset() check in one case, so this patch should fix the issue.
Comment #4
agentrickardComment #5
karnal69 commentedBrilliant - worked perfectly! Thanks heaps for that.
On a side note, I mentioned it was only happening when not on the 'front' page. It also turns out that (before the patch), the error was also not occurring when using domain-specific paths that were set. So if I got the error on subdomain.mydomain.com/node/10 and node 10 has a domain specific path of 'products', the error would occur at /node/10 but not with /products, even though they are the same page (For some strange reason, my menus are not translating the node path into a clean URL, but that's another issue). Not sure if that's useful to you...
Anyway, thanks again for the patch (and the module - great stuff!)
Cheers,
K.
Comment #6
agentrickardComment #7
agentrickardCommitted to 7.x.2 and 7.x.3.
Comment #9
mikeytown2 commentedBackport for 6.x branch.
Comment #10
agentrickardCommitted.