While in certain circumstances it could be a security issue, it would be beneficial to be able to directly upload a new JS file from the admin rather than having to upload it & then change the variable; this would allow the task to be delegated to someone who was responsible for the Omniture configuration rather than the site developer.

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

As long as the ability to do so is controlled by a permission on http://drupal.org/node/475848 - like "administer site configuration" - I see no problem with it.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

This would've been useful for me too. I was supplied with a JS file to host on the site - ended up putting it in the 'js' directory of another module, but it's "out of position", so to speak.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Ability to directly upload a new JS file » Include an extra js file from a good location

It makes sense to me for the module to offer this.

The standard place is becoming sites/all/libraries/omniture/

@greg.harvey or DamienMcKenna - What was the name of the file?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The file is normally named s_code.js.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Include an extra js file from a good location » Optionally include the s_code.js file from a good location
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The documentation might also want to be spruced up to explain how to use the s_account and s.dynamicAccountList variables in the s_code.js file in order to use one file for multiple sites:

egomac’s picture

egomac commented

just curious if s_code.js can be included using drupal_add_js() so that it becomes part of the aggregated js when the js aggregation is turned on.