Split up module css

I'd say classes that are "just needed" and don't go to a specific module should get adopted by system.module. It's the closest to core of all the modules, and by nature is always included. I'd just put them all in a single system.css file.

There should be no css files that are not part of some module or another.

Nice patch, applies cleanly to HEAD..
I'm tempted to set this RTBC, but lets wait untill someone else reviews this..

Steef

I actually disagree with Crell... to maintain consistency, all rules in module CSS files should be specific to those modules. Stuff like "img" and "table" extend far beyond the system module itself, and thus they should be in the more "global" drupal.css file.

The one thing that still sort of feels "wrong" is having things like #block and #taxonomy in drupal.css. There are also items in drupal.css currently which seem to belong to user and system. I would make the following changes (I tried to do this myself, but have no idea how to roll a patch which requires adding files, so I'll just put this for you for when you get back :P):

Add to block.css:

#blocks td.region {
  font-weight: bold;
}
#blocks td.block {
  padding-left: 1.5em;
}

Add to system.css:

img.screenshot {
  border: 1px solid #808080;
  display: block;
  margin: 2px;
}
.theme-settings-left {
  float: left;
  width: 49%;
}
.theme-settings-right {
  float: right;
  width: 49%;
}
.theme-settings-bottom {
  clear: both;
}

Move into user.css:

#permissions td.module {
  font-weight: bold;
}
#permissions td.permission {
  padding-left: 1.5em;
}
#access-rules .access-type, #access-rules .rule-type {
  margin-right: 1em;
  float: left;
}
#access-rules .access-type .form-item, #access-rules .rule-type .form-item {
  margin-top: 0;
}
#access-rules .mask {
  clear: both;
}
#user-login-form {
  text-align: center;
}

There seems to be a fair amount of "dead" CSS that isn't called from anywhere in core (for example, .more-link), but I figure removing that will be a separate patch.

My reasoning for saying that system.module should adopt non-module-specific classes is as follows:

1) Consistency. We now have a way for modules to add stylesheets and themes to remove them. Great. Let's not also have a non-module stylesheet to worry about. If themes need only worry about module-originating stylesheets, that makes the job easier for theme authors. It's one fewer variable to deal with.

2) I see system as "the core module". Things like img and table are part of the "core system", and therefore make logical sense with the "core system" module.

It wouldn't surprise me in the least if there's some dead cruft in drupal.css. Hopefully by splitting it up completely to the appropriate modules, we'll be able to divide and conquer and remove it. That will likely happen over the course of several patches.

Hmm,
currently all of the module's css files are added in the menu hook, so on every page request.
Wouldn't it be better if some of the files would only be included when they are actually needed?
For example, only including book.css when actuallly viewing a book node, or aggregator.css only on pages where it's needed and so on...

I think it'd be cool if we could manage to get rid of the misc/ directory entirely , actually.

I too see system.module as the core system. In the dependency work, EVERYTHING has a implicit requirement of system.module.
(it's also the module that has the drupal version, and the system.install file)

* I agree: /misc should be removed entirely and we should strive for that.
* I agree: /system/system.css for non-specific stylesheet rules.
* Uber generic crap like "img" and "table" should really become theme-specific, I'd think.

* I agree with Frando: we should only spit the CSS when the module actually uses it.

Updated the patch and fixed the wrong usage of drupal_add_css().

Kudos for patches such as this! I've had a beef with drupal.css for a while now... here are some further points of contention:

- Too much is defined by the default CSS. While this does make things easier to theme, it also discourages theme creators to think outside of the box and define things for themselves. The system CSS should be kept to an absolute bare minimum to increase creativity and cut down on the time/bytes wasted in over-riding system values.
- The default html created in php template is class/id/div happy. I am all for hooks, but some things can be simplified by using better selectors. For example, .leaf is un-needed for generic menu list items and just creates clutter. A simpler way would be to get rid of all leaf classes and change the CSS selector to ul.menu li (or something similar).

Maybe this complaints go beyond the scope of this patch. Either way, system CSS will be much improved in this release.

Excellent work! This'll be so nice.

If this happens, then we can start attacking the styles for the new admin page :)

I kind of don't like losing the useful ability of drupal.css to easily identify a Drupal site, but I'm also not a themer so will defer to others on that.

Webchick: Irrelevant, I'd say. There are many other signatures of a Drupal install, such as user/register.

Pish. I can usually recognize a drupal site just by its functionality. I don't need drupal.css for that. :-)

That said, when I applied this patch drupal.css didn't disappear. There were also some offsets (big deal), but now that the archive module is gone this patch is out of date because it tries to add an archive.css file. Setting back to needs work for those reasons.

I also did a quick read-through of the post-patch CSS files. profile.css now includes this rule, which probably belongs in the poll module:

.node-form .poll-form fieldset {
  display: block;
}

In system.css, there are two rules right next to each other:

tr.even, tr.odd {
  background-color: #eee;
  border-bottom: 1px solid #ccc;
}
tr.even, tr.odd {
  padding: 0.1em 0.6em;
}

Unless I'm going blind, there's no reason those shouldn't be a single rule. I know this isn't supposed to be a cleanup patch, but if we're moving them, that one seems just too trivial to not fix. Also, I'm not sure off hand if this rule should be part of the path module, as I'm not sure what it does. :-) Someone who knows check me on this:

.path {
  padding-bottom: 0.7em;
  font-size: 1.1em;
}

I like the system.css / default.css split. Spiffy!

Other that, everything looks good. Fix these up soon, please! So many people have been waiting for the death of drupal.css. :-)

If nobody does the pdate of the patch within the next 24 hours, I'll take a shot at this.
IMO this is a must-have in core..

BTW: Very nice patch m3avrck!

Applies perfectly against current HEAD, with one caveat. drupal.css itself is not actually removed. :-) Is that something only Dries/drumm/Steven can do?

Assuming yes, and dDS can take care of that part, I'll go on a limb and RTBC this. Yay!

Committed to HEAD with editing for adding a newline at the end of all the new CSS files and not letting system_menu() break Drupal. Thanks for (hopefully) not trying to sneak in wider changes (removing rules) with this patch.

Some image files need to be moved, such as the menu bullets. Please make a complete list and mark ready to commit.

I only found 3 references to images in the new CSS files, all 3 in menu module:

menu-expanded.png
menu-collapsed.png
menu-leaf.png

Which seemed off to me, so I went back and checked drupal.css, and discovered that, erm, a whole bunch of rules went missing. :-( Mostly they relate to JS functionality. They also reference a few other images:

throbber.gif
progress.gif
grippie.png

And also re-reference:
menu-expanded.png
menu-collapsed.png

I'm going to suggest those go to system module (including duplicates of the menu images), and system.css pick up the extra JS classes. I've attached a patch that adds them back in.

Sorry, Neil. We really screwed up on this one. :-(

(Although it does look like there's a bunch of graphics in misc that core doesn't actually use. If they're used by a core theme, they should get moved to the theme. Another time.)

I think the css rules for the welcome page and admin page are missing as well

Not "img/", please. "img" is an abomination abbreviation in HTML. Let's not force it into the fs too. images/ please.

sounds like you've already noticed and are working on the menu images problem. that saves me the trouble of one of the screenshots i was going to post. ;) the other i noticed is the login block is no longer centered. see attached .png

also, m3avrck said in #28 "here's a new patch", but he never attached it. ;) so, i'm setting this back to "needs work", since there's definitely nothing in here that's RTBC at the moment.

fresh, clear core test site, applied patch from #34, cleared browser cache, drupal cache, and reset drupal menus. menu icons are still busted (though admin page css is working again). see attached.

yup, patch #37 fixes all the problems i was seeing. login block is right, menu icons are working, and admin pages look reasonable. RTBC, indeed. thanks, m3avrck!

Committed this to CVS HEAD to fix some of the breakage.

Committed to HEAD.