The CSS path indicated for the HTML in the editor window is attached by javascript. Javascript caches all URLs/Pathes so this CSS is also violently cached by the browser, which created very significant problems for themers - once they indicate custom CSS file, and start editing it, all edits after the first one are ignored, until you clear browser cache or restart browser. It almost makes the feature unusable.

Attached patch adds ?nocache=[timestamp] at the end of the CSS file path to avoid caching (it's obviously not a performance issue since content edit screen is not a performance-sensitive page, anyway).

CommentFileSizeAuthor
#1 ckeditor.module-772134.patch819 bytesirakli

Comments

irakli’s picture

StatusFileSize
new819 bytes
irakli’s picture

Title: Avoid Javascript Catching of editor CSS » Avoid Javascript Caching of editor CSS
Priority: Normal » Critical
mephir’s picture

Status: Active » Needs review

i'll review that asap and commit changes. Thanks for help.

jcisio’s picture

Status: Needs review » Needs work

I don't think it is not a performance issue. Every node view page normally has a comment form, and CKEditor of course can be use for comment.

The number of CSS can be large, especially when theme breaks stylesheet into a couple files for logic seperation.

Versionning is ok, but not timestamp, please.

mephir’s picture

My propose is that, if choose ckeditor_source.js load method, 5this time stamp will be added automatically.

mephir’s picture

Status: Needs work » Fixed

Changes commited into CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.