Case-sensitive user name checking

User names are checked in a case-sensitive manner, which is a problem on PostgreSQL. (forum topic)

Patch below. Please note I commented out some other code which has a 'mySQL specific' comment attached... I don't know what should be done with that (and if it works on PostgreSQL anyway; I didn't try).

--- /usr/local/pkg/drupal/drupal-4.4.1/modules/user.module      2004-05-02 17:45:30.000000000 +0200
+++ modules/user.module 2004-05-11 21:30:10.000000000 +0200
@@ -34,7 +34,7 @@
       $query .= "u.$key = '". md5($value) ."' AND ";
     }
     else {
-      $query .= "u.$key = '". check_query($value) ."' AND ";
+      $query .= "LOWER(u.$key) = '". strtoLower(check_query($value)) ."' AND ";
     }
   }
   $result = db_query_range("SELECT u.*, r.name AS role FROM {role} r INNER JOIN {users} u ON r.rid = u.rid WHERE $query u.
status < 3", 0, 1);
@@ -296,11 +296,7 @@
 
 function user_search($keys) {
   $find = array();
-
-  // Replace wildcards with mysql wildcards
-  $keys = str_replace("*", "%", $keys);
-
-  $result = db_query_range("SELECT * FROM {users} WHERE name LIKE '%%%s%%'", $keys, 0, 20);
+  $result = db_query_range("SELECT * FROM {users} WHERE LOWER(name) LIKE '%%%s%%'", strtoLower($keys), 0, 20);
   while ($account = db_fetch_object($result)) {
     $find[] = array("title" => $account->name, "link" => (strstr(request_uri(), "admin") ? url("admin/user/edit/$account->
uid") : url("user/view/$account->uid")), 'user' => $account->name);
   }
@@ -700,11 +696,11 @@
   global $base_url;
 
   if ($edit['name']) {
-    $account = db_fetch_object(db_query("SELECT uid, name, mail FROM {users} WHERE status = 1 AND name = '%s'", $edit['nam
e']));
+    $account = db_fetch_object(db_query("SELECT uid, name, mail FROM {users} WHERE status = 1 AND LOWER(name) = '%s'", str
toLower($edit['name'])));
     if (!$account) $error = t("Sorry. The username <i>%s</i> is not recognized.", array("%s" => $edit['name']));
   }
   else if ($edit['mail']) {
-    $account = db_fetch_object(db_query("SELECT uid, name, mail FROM {users} WHERE status = 1 AND mail = '%s'", $edit['mai
l']));
+    $account = db_fetch_object(db_query("SELECT uid, name, mail FROM {users} WHERE status = 1 AND LOWER(mail) = '%s'", str
toLower($edit['mail'])));
     if (!$account) $error = t("Sorry. The e-mail address <i>%s</i> is not recognized.", array("%s" => $edit['mail']));
   }
   if ($account) {