The idea behind "DELAY" is to allow queries that don't need to commit immediately to just kinda happen when they get there. However, it is not part of standard SQL. It doesn't work on PostgreSQL or SQLite. It only works on MySQL. However, it only works on the MyISAM table type. Drupal 7 on MySQL now defaults to InnoDB, where DELAY is ignored. So really, it's an edge case that we don't even use.
Should we just get rid of it and save ourselves the hassle?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | kill-delay.patch | 2.37 KB | jbrown |
| #1 | 772554-delay.patch | 2.52 KB | Crell |
Comments
Comment #1
Crell commentedI couldn't find anywhere that we were using delay() in the first place.
Comment #2
chx commentedTotally. DELAYED means "the day when my database melts down has been delayed by an undefined amount of time". Using INSERT DELAYED adds a lot of interesting problems and altogether you might end up with a lower INSERT performance. More importantly you give up control on what happens with your database. Bad idea.
Comment #3
webchickYay for less code! :) Committed to HEAD.
Comment #5
jbrown commentedThere is more code to be removed.
I also removed the docs: http://drupal.org/node/310079/revisions/view/773668/1024872
Comment #6
aspilicious commentedLooks good
Comment #7
Crell commentedDagnabbit, I thought I got some of those. Thanks, jbrown.
Comment #8
dries commentedCommitted to CVS HEAD. Thanks.