Closed (fixed)
Project:
Provision
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Apr 2010 at 20:45 UTC
Updated:
12 Jun 2014 at 08:41 UTC
Jump to comment: Most recent, Most recent file
Hi guys - I'm using Provision as currently installed by the head version of Aegir from the last week - I don't see version numbers in anything under ~aegir/.drush/provision, unfortunately.
Anyways, this is the last 15 lines or so of a given platform config file created by provision, as found under ~aegir/config/platform.d:
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteCond %{REQUEST_URI} !=/favicon.ico
RewriteRule ^(.*)$ index.php?q=$1 [L,QSA]
</IfModule>
# $Id: .htaccess,v 1.90.2.5 2010/02/02 07:25:22 dries Exp $
<IfModule mod_rewrite.c>
# allow files to be accessed without /sites/fqdn/
RewriteRule ^files/(.*)$ /sites/%{HTTP_HOST}/files/$1 [L]
</IfModule>
# Do not read the platform's .htaccess
AllowOverride none
</Directory>
Note the RewriteRule for the /files alias occurs after the main drupal RewriteRule - this results in the rule being ignored.
I can it's being placed there by provision_drupal_provision_apache_dir_config() in verify.provision.inc, but my Drupal-fu's not quite good enough yet to see what's calling that and submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 772616.patch | 1.36 KB | mig5 |
Comments
Comment #1
benkant commentedI can confirm this problem exists in 0.4a7
I even tried adding:
to config/platform.d/platform_n.conf inside the
block... still no dice. Any ideas?
Comment #2
Anonymous (not verified) commentedThe L flag in the default .htaccess block causes the entry to be ignored. We used to stick it in the start of the IfModule block just under REwriteEngine On for this purpose.
Need to try and insert it into that block programatically, or (easier) perhaps just stick our block at the *start* of the config and read in the .htaccess after that.
Comment #3
Anonymous (not verified) commentedOK, here's a hotfix patch for this that will work
But it's a little ugly, we should not have multiple IfModules all over the place in the config that are calling RewriteEngine On multiple times (it doesn't break anything, but it's not nice)
We really need to make our own injections into the .htaccess be more modular, i.e have a 'provision_apache_rewrite_config' hook that will bundle them all up and stick them in the one grouping in the config.
Comment #4
proindustries commentedYep, verified that'll work for now...thx!
Comment #5
acThe symptoms of this bug are still present in ALPHA8. Not sure if they stem from the same code issue as it seems the code has been patched.
Comment #6
acchanging status as this is broken in ALPHA8.
Here is a copy of a platform.conf file:
Comment #7
acArg this was the result of upgrading from an older aegir instance where the aegir vhost files were included using a line in apache.conf. The new method of symlinking from /etc/apache2/conf.d hadn't been included so no platform apache directives were loaded.
This issue seems to be fixed in the new alpha so I am marking it closed. Please reopen if you find an issue.