CVS edit link for anthonysomerset

wishing to release modules developed for me and the company i work for back into the community for community benefit and improvement.

first module wishing to be released is a google form module which as of yet nothing with similar functionality exists but the basics are that it pulls the form via curl and embeds it in a block for display on a drupal site in the sites theme and not using an iframe which is undesirable in most cases

CommentFileSizeAuthor
#5 google_form0.3.zip7.56 KBanthonysomerset
#3 google_form0.2.zip7.56 KBanthonysomerset
#1 google_form.zip13.56 KBanthonysomerset

Comments

anthonysomerset’s picture

anthonysomerset commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new google_form.zip13.56 KB

attaching first module version of google_form

Main Features of Module:

  • embed google form within a block to use own themes formatting
  • uses form key to pull the form down from google via curl
  • form data is submitted direct into google form as the normal google form process happens
  • avoids use of iframes

example of a google form as rendered by drupal in use here.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

The simple_html_dom library should not be part of this module. You may want to investigate usage of http://drupal.org/project/libraries, but there are also other/custom ways to include an externally downloaded library.

anthonysomerset’s picture

anthonysomerset commented
StatusFileSize
new google_form0.2.zip7.56 KB

new version attached without the lib and using libraries api to locate it, basic readme in place showing the dependancy on the libraries api module and the simplehtmldom lib (i am aware this will need fleshing out properly with a full readme)

anthonysomerset’s picture

anthonysomerset commented
Status: Needs work » Needs review
anthonysomerset’s picture

anthonysomerset commented
StatusFileSize
new google_form0.3.zip7.56 KB

fixed libraries api implementation to correct path usage

anthonysomerset’s picture

anthonysomerset commented

can anyone advise as to the progress of this and if there is anything i need to specifically do beyond what is already said?

many thanks

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

You should be using http://api.drupal.org/api/function/drupal_http_request/6 instead of raw cURL.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Needs work

I will review the code within 6 days. For sure, I will not review it before two days are passed; you can take this time to check what sun reported. I am marking this report as needs work to let you notice this comment.

anthonysomerset’s picture

anthonysomerset commented
Status: Needs work » Needs review

thanks for the update

i have to admit i am having major troubles trying to convert the curl parts of the code to using the http_request api but this is likely lack of knowledge on my part at this stage

marking as needs review again to reflect your post :)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
  1. Strings used in the user interface should be in sentence case.
  2. The first parameter of t() is a literal string; dynamic strings passed to the function are not translated, if not in the case another module is using a literal string with the same content (which would rarely happen).
  3. As reported by sun, the module should use the Drupal function.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)