The default behavior of content_moderation is now to only let the latest revision be moderateable. That means, that you only can change the state of the latest revisions, or to be even more presize, you cannot approve a revision which is older then the latest. This also includes, that you cannot edit the node when the latest revision is under moderation, so does not have the status none.

If you ask yourself, why this is needed, its not to easy to explain:

1. If you have a live revision 1, and also pending revisions 2, 3, 4. Now you try to review, approve and set live revision 2, what was possible before.
2. In the review state the reviewer happens to see a typo and want to correct that one. What happens now?
3. You cannot edit revisions in drupal, as this actually be a branch. Lets say it would be possible like suggested here #683328: Make revisions editable (branching)
4. That would mean, you might have a revision 2.a, then maybe 2.b to correct all the typos.
5. Now you set this 2.b live and yes, it would work
6. But the quesion now is, what is about revision 3 and 4? They still include the typos, the dont have your changes 2.a and 2.b. You would have to merge, and that wont be trivial.
7. And in addition, while you where moderating 2, people would have edited further on, create revision 4,5,6
8. Also those revisions would not have the changes - in addition a merge might need to be even semantic then.

To sum up, being able to edit during moderation or moderate not the latest revision is pretty dangerous and should only be activated if you can handle those branches / merges.

For the default case we have the more simppel approach now:
1. You can edit the node, while it has a live version ( or no live version ) as you wish
2. As expected, if you have a live version, the visible version never changes ( and is locked to the live version)
3. When you decide to review the latest revision, you set it to review
4. If the reviewer happens to find a typo, he will need to set back the status to none
5. then he is able to edit and correct all the typos.
6. Now finally you can set review once again, and the reviewer might give his ok
7. Now approve and set the version live and you are done
8. You can now edit once again, as you dont have any pending revisions in moderation ( only live or none)

Comments

eugenmayer’s picture

eugenmayer commented
Status: Active » Fixed

Is included in the git repo http://github.com/EugenMayer/content_moderation and will be release with 1.3.

Be aware when you upgrade, as this can potentially lock current nodes. Because if you allready have pending revisions which are not the latest but still in moderation, you will not be able to change their state after the upgrade.

To fix this, please got to the configuration page admin/settings/content_moderation/general
1. uncheck the "Edit stop on revision moderated"
2. Change all the nodes with those revisions and "unmoderate" those revisions. So set them live or none
3. switch the feature back on

eugenmayer’s picture

eugenmayer commented
Status: Fixed » Closed (fixed)